netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: jiangheng <15720603159@163.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2]rdma: modify the command output message of rdma statistic help based on man manual
Date: Tue, 16 Aug 2022 16:49:55 +0300	[thread overview]
Message-ID: <Yvugg0M22X1Vua7M@unreal> (raw)
In-Reply-To: <25ce8a4f.6db0.182910b625a.Coremail.15720603159@163.com>

On Fri, Aug 12, 2022 at 03:53:38PM +0800, jiangheng wrote:
> 
> From 4ce8d60f34c5cdcff8b25e3c3891fc053736225b Mon Sep 17 00:00:00 2001
> From: jinag <jinag12138@gmail.com>
> Date: Fri, 12 Aug 2022 15:48:07 +0800
> Subject: [PATCH] rdma: modify the command output message of rdma statistic help
>  based on man manual
> 
> 
> ---
>  rdma/stat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

iproute2 follows kernel coding style, both in the code
and in the patches. Please follow it.

Thanks

> 
> 
> diff --git a/rdma/stat.c b/rdma/stat.c
> index aad8815c..1e869c25 100644
> --- a/rdma/stat.c
> +++ b/rdma/stat.c
> @@ -24,10 +24,10 @@ static int stat_help(struct rd *rd)
>     pr_out("       %s statistic mode [ supported ] link [ DEV/PORT_INDEX ]\n", rd->filename);
>     pr_out("       %s statistic set link [ DEV/PORT_INDEX ] optional-counters [ OPTIONAL-COUNTERS ]\n", rd->filename);
>     pr_out("       %s statistic unset link [ DEV/PORT_INDEX ] optional-counters\n", rd->filename);
> -   pr_out("where  OBJECT: = { qp }\n");
> -   pr_out("       CRITERIA : = { type }\n");
> +   pr_out("where  OBJECT: = { qp | mr }\n");
> +   pr_out("       CRITERIA : = { type | pid }\n");
>     pr_out("       COUNTER_SCOPE: = { link | dev }\n");
> -   pr_out("       FILTER_NAME: = { cntn | lqpn | pid }\n");
> +   pr_out("       FILTER_NAME: = { cntn | lqpn | pid | qp_type }\n");
>     pr_out("Examples:\n");
>     pr_out("       %s statistic qp show\n", rd->filename);
>     pr_out("       %s statistic qp show link mlx5_2/1\n", rd->filename);
> --
> 2.23.0

      reply	other threads:[~2022-08-16 13:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  7:53 [PATCH iproute2]rdma: modify the command output message of rdma statistic help based on man manual jiangheng
2022-08-16 13:49 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yvugg0M22X1Vua7M@unreal \
    --to=leon@kernel.org \
    --cc=15720603159@163.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).