netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2]rdma: modify the command output message of rdma statistic help based on man manual
@ 2022-08-12  7:53 jiangheng
  2022-08-16 13:49 ` Leon Romanovsky
  0 siblings, 1 reply; 2+ messages in thread
From: jiangheng @ 2022-08-12  7:53 UTC (permalink / raw)
  To: netdev


From 4ce8d60f34c5cdcff8b25e3c3891fc053736225b Mon Sep 17 00:00:00 2001
From: jinag <jinag12138@gmail.com>
Date: Fri, 12 Aug 2022 15:48:07 +0800
Subject: [PATCH] rdma: modify the command output message of rdma statistic help
 based on man manual


---
 rdma/stat.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


diff --git a/rdma/stat.c b/rdma/stat.c
index aad8815c..1e869c25 100644
--- a/rdma/stat.c
+++ b/rdma/stat.c
@@ -24,10 +24,10 @@ static int stat_help(struct rd *rd)
    pr_out("       %s statistic mode [ supported ] link [ DEV/PORT_INDEX ]\n", rd->filename);
    pr_out("       %s statistic set link [ DEV/PORT_INDEX ] optional-counters [ OPTIONAL-COUNTERS ]\n", rd->filename);
    pr_out("       %s statistic unset link [ DEV/PORT_INDEX ] optional-counters\n", rd->filename);
-   pr_out("where  OBJECT: = { qp }\n");
-   pr_out("       CRITERIA : = { type }\n");
+   pr_out("where  OBJECT: = { qp | mr }\n");
+   pr_out("       CRITERIA : = { type | pid }\n");
    pr_out("       COUNTER_SCOPE: = { link | dev }\n");
-   pr_out("       FILTER_NAME: = { cntn | lqpn | pid }\n");
+   pr_out("       FILTER_NAME: = { cntn | lqpn | pid | qp_type }\n");
    pr_out("Examples:\n");
    pr_out("       %s statistic qp show\n", rd->filename);
    pr_out("       %s statistic qp show link mlx5_2/1\n", rd->filename);
--
2.23.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute2]rdma: modify the command output message of rdma statistic help based on man manual
  2022-08-12  7:53 [PATCH iproute2]rdma: modify the command output message of rdma statistic help based on man manual jiangheng
@ 2022-08-16 13:49 ` Leon Romanovsky
  0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-08-16 13:49 UTC (permalink / raw)
  To: jiangheng; +Cc: netdev

On Fri, Aug 12, 2022 at 03:53:38PM +0800, jiangheng wrote:
> 
> From 4ce8d60f34c5cdcff8b25e3c3891fc053736225b Mon Sep 17 00:00:00 2001
> From: jinag <jinag12138@gmail.com>
> Date: Fri, 12 Aug 2022 15:48:07 +0800
> Subject: [PATCH] rdma: modify the command output message of rdma statistic help
>  based on man manual
> 
> 
> ---
>  rdma/stat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

iproute2 follows kernel coding style, both in the code
and in the patches. Please follow it.

Thanks

> 
> 
> diff --git a/rdma/stat.c b/rdma/stat.c
> index aad8815c..1e869c25 100644
> --- a/rdma/stat.c
> +++ b/rdma/stat.c
> @@ -24,10 +24,10 @@ static int stat_help(struct rd *rd)
>     pr_out("       %s statistic mode [ supported ] link [ DEV/PORT_INDEX ]\n", rd->filename);
>     pr_out("       %s statistic set link [ DEV/PORT_INDEX ] optional-counters [ OPTIONAL-COUNTERS ]\n", rd->filename);
>     pr_out("       %s statistic unset link [ DEV/PORT_INDEX ] optional-counters\n", rd->filename);
> -   pr_out("where  OBJECT: = { qp }\n");
> -   pr_out("       CRITERIA : = { type }\n");
> +   pr_out("where  OBJECT: = { qp | mr }\n");
> +   pr_out("       CRITERIA : = { type | pid }\n");
>     pr_out("       COUNTER_SCOPE: = { link | dev }\n");
> -   pr_out("       FILTER_NAME: = { cntn | lqpn | pid }\n");
> +   pr_out("       FILTER_NAME: = { cntn | lqpn | pid | qp_type }\n");
>     pr_out("Examples:\n");
>     pr_out("       %s statistic qp show\n", rd->filename);
>     pr_out("       %s statistic qp show link mlx5_2/1\n", rd->filename);
> --
> 2.23.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-16 13:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-12  7:53 [PATCH iproute2]rdma: modify the command output message of rdma statistic help based on man manual jiangheng
2022-08-16 13:49 ` Leon Romanovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).