From: Andrew Lunn <andrew@lunn.ch>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next v2 02/16] net: txgbe: Reset hardware
Date: Thu, 1 Sep 2022 02:03:07 +0200 [thread overview]
Message-ID: <Yw/2u746uEk85S7u@lunn.ch> (raw)
In-Reply-To: <025801d8bce5$0423b010$0c6b1030$@trustnetic.com>
On Wed, Aug 31, 2022 at 10:54:40AM +0800, Jiawen Wu wrote:
> On Wednesday, August 31, 2022 8:39 AM, Andrew Lunn wrote:
> > n Tue, Aug 30, 2022 at 03:04:40PM +0800, Jiawen Wu wrote:
> > > /* struct txgbe_mac_operations */
> > > +static int txgbe_stop_adapter_dummy(struct txgbe_hw *TUP0) {
> > > + return -EPERM;
> >
> > This is a bit of an odd error code. -EOPNOTSUPP would be more normal.
> >
> > I do wonder what all this dummy stuff is for...
> >
>
> Okay, I just think that this way I don't need to determine whether the
> function pointer is NULL every time it is called.
Have you seen many other driver doing this? I don't think i have. They
just check the pointer before calling thought it. You want your driver
to look just like every other Linux Ethernet driver.
Andrew
next prev parent reply other threads:[~2022-09-01 0:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 7:04 [PATCH net-next v2 00/16] net: WangXun txgbe ethernet driver Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 01/16] net: txgbe: Store PCI info Jiawen Wu
2022-08-31 0:06 ` Andrew Lunn
2022-08-31 2:20 ` Jiawen Wu
2022-08-31 23:59 ` Andrew Lunn
2022-08-30 7:04 ` [PATCH net-next v2 02/16] net: txgbe: Reset hardware Jiawen Wu
2022-08-31 0:39 ` Andrew Lunn
2022-08-31 2:54 ` Jiawen Wu
2022-09-01 0:03 ` Andrew Lunn [this message]
2022-08-30 7:04 ` [PATCH net-next v2 03/16] net: txgbe: Set MAC address and register netdev Jiawen Wu
2022-08-31 1:02 ` Andrew Lunn
2022-09-22 9:58 ` Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 04/16] net: txgbe: Add operations to interact with firmware Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 05/16] net: txgbe: Identify PHY and SFP module Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 06/16] net: txgbe: Initialize service task Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 07/16] net: txgbe: Support to setup link Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 08/16] net: txgbe: Add interrupt support Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 09/16] net: txgbe: Handle various event interrupts Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 10/16] net: txgbe: Configure Rx and Tx unit of the MAC Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 11/16] net: txgbe: Allocate Rx and Tx resources Jiawen Wu
2022-08-30 23:31 ` kernel test robot
2022-08-30 7:04 ` [PATCH net-next v2 12/16] net: txgbe: Add Rx and Tx cleanup routine Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 13/16] net: txgbe: Add device Rx features Jiawen Wu
2022-09-03 19:50 ` kernel test robot
2022-08-30 7:04 ` [PATCH net-next v2 14/16] net: txgbe: Add transmit path to process packets Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 15/16] net: txgbe: Support to get system network statistics Jiawen Wu
2022-08-30 7:04 ` [PATCH net-next v2 16/16] net: txgbe: support to respond Tx hang Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw/2u746uEk85S7u@lunn.ch \
--to=andrew@lunn.ch \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).