From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jakub Kicinski <kuba@kernel.org>,
Frank <Frank.Sae@motor-comm.com>,
Peter Geis <pgwipeout@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
yinghong.zhang@motor-comm.com, fei.zhang@motor-comm.com,
hua.sun@motor-comm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4.4] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy
Date: Tue, 23 Aug 2022 21:19:52 +0100 [thread overview]
Message-ID: <YwU2aFOKaMGVLWq7@shell.armlinux.org.uk> (raw)
In-Reply-To: <YwUiQgSGBhbvk7T6@lunn.ch>
On Tue, Aug 23, 2022 at 08:53:54PM +0200, Andrew Lunn wrote:
> > > The user could of changed the pause settings, which are going to be
> > > ignored here. Also, you should not assume the MAC can actually do
> > > asymmetric pause, not all can. phydev->advertising will be set to only
> > > include what the MAC can actually do.
>
> > Interesting. Just to confirm - regardless of the two-sided design..
> > -edness.. IIUC my question has merit and we need v5?
>
> Yes, phydev->advertising should be take into account.
It's worth pointing out that there is a helper for this -
linkmode_adv_to_mii_adv_x().
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2022-08-23 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 11:25 [PATCH v4.4] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy Frank
2022-08-23 3:21 ` Jakub Kicinski
2022-08-23 14:14 ` Andrew Lunn
2022-08-23 18:37 ` Jakub Kicinski
2022-08-23 18:53 ` Andrew Lunn
2022-08-23 20:19 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwU2aFOKaMGVLWq7@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fei.zhang@motor-comm.com \
--cc=hkallweit1@gmail.com \
--cc=hua.sun@motor-comm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=yinghong.zhang@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).