From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@nvidia.com,
pabeni@redhat.com, edumazet@google.com, saeedm@nvidia.com,
jacob.e.keller@intel.com, vikas.gupta@broadcom.com,
gospo@broadcom.com
Subject: Re: [patch net-next v2 1/4] net: devlink: extend info_get() version put to indicate a flash component
Date: Wed, 24 Aug 2022 10:50:29 +0200 [thread overview]
Message-ID: <YwXmVTs79zVMdBDJ@nanopsycho> (raw)
In-Reply-To: <20220823123208.61487225@kernel.org>
Tue, Aug 23, 2022 at 09:32:08PM CEST, kuba@kernel.org wrote:
>On Tue, 23 Aug 2022 08:35:04 +0200 Jiri Pirko wrote:
>> Tue, Aug 23, 2022 at 05:00:26AM CEST, kuba@kernel.org wrote:
>> >On Mon, 22 Aug 2022 19:02:44 +0200 Jiri Pirko wrote:
>> >> +int devlink_info_version_running_put_ext(struct devlink_info_req *req,
>> >> + const char *version_name,
>> >> + const char *version_value,
>> >> + enum devlink_info_version_type version_type);
>> >
>> >Why are we hooking into running, wouldn't stored make more sense?
>>
>> I think eventually this should be in both. Netdevsim and mlxsw (which I
>> did this originally for) does not have "stored".
>
>Well, netdevsim is just API dust, and mlxsw is incorrect :/
Okay, will add "stored".
next prev parent reply other threads:[~2022-08-24 8:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 17:02 [patch net-next v2 0/4] net: devlink: sync flash and dev info commands Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 1/4] net: devlink: extend info_get() version put to indicate a flash component Jiri Pirko
2022-08-23 3:00 ` Jakub Kicinski
2022-08-23 6:35 ` Jiri Pirko
2022-08-23 19:32 ` Jakub Kicinski
2022-08-24 8:50 ` Jiri Pirko [this message]
2022-08-22 17:02 ` [patch net-next v2 2/4] netdevsim: add version fw.mgmt info info_get() and mark as a component Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 3/4] net: devlink: limit flash component name to match version returned by info_get() Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 4/4] net: devlink: expose the info about version representing a component Jiri Pirko
2022-08-23 3:01 ` Jakub Kicinski
2022-08-23 6:36 ` Jiri Pirko
2022-08-23 19:31 ` Jakub Kicinski
2022-08-24 8:49 ` Jiri Pirko
2022-08-24 17:31 ` Keller, Jacob E
2022-08-24 18:12 ` Jakub Kicinski
2022-08-24 18:46 ` Keller, Jacob E
2022-08-24 19:49 ` Andy Gospodarek
2022-08-22 19:23 ` [patch net-next v2 0/4] net: devlink: sync flash and dev info commands Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwXmVTs79zVMdBDJ@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).