From: Jiri Pirko <jiri@resnulli.us>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, alexandr.lobakin@intel.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
marcin.szycik@linux.intel.com,
michal.swiatkowski@linux.intel.com, kurt@linutronix.de,
boris.sukholitko@broadcom.com, vladbu@nvidia.com,
komachi.yoshiki@gmail.com, paulb@nvidia.com,
baowen.zheng@corigine.com, louis.peens@corigine.com,
simon.horman@corigine.com, pablo@netfilter.org,
maksym.glubokiy@plvision.eu, intel-wired-lan@lists.osuosl.org,
jchapman@katalix.com, gnault@redhat.com
Subject: Re: [RFC PATCH net-next 0/5] ice: L2TPv3 offload support
Date: Fri, 26 Aug 2022 13:16:00 +0200 [thread overview]
Message-ID: <YwircDhHhOfqdHy/@nanopsycho> (raw)
In-Reply-To: <20220826110059.119927-1-wojciech.drewek@intel.com>
Fri, Aug 26, 2022 at 01:00:54PM CEST, wojciech.drewek@intel.com wrote:
>Add support for dissecting L2TPv3 session id in flow dissector. Add support
>for this field in tc-flower and support offloading L2TPv3. Finally, add
>support for hardware offload of L2TPv3 packets based on session id in
>switchdev mode in ice driver.
>
>Example filter:
> # tc filter add dev $PF1 ingress prio 1 protocol ip \
> flower \
> ip_proto l2tp \
> l2tpv3_sid 1234 \
> skip_sw \
> action mirred egress redirect dev $VF1_PR
>
>Changes in iproute2 are required to use the new fields.
>
>ICE COMMS DDP package is required to create a filter in ice.
I don't understand what do you mean by this. Could you please explain
what this mysterious "ICE COMMS DDP package" is? Do I understand it
correctly that without it, the solution would not work?
>
>Marcin Szycik (1):
> ice: Add L2TPv3 hardware offload support
>
>Wojciech Drewek (4):
> uapi: move IPPROTO_L2TP to in.h
> flow_dissector: Add L2TPv3 dissectors
> net/sched: flower: Add L2TPv3 filter
> flow_offload: Introduce flow_match_l2tpv3
>
> .../ethernet/intel/ice/ice_protocol_type.h | 8 +++
> drivers/net/ethernet/intel/ice/ice_switch.c | 70 ++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 27 ++++++-
> drivers/net/ethernet/intel/ice/ice_tc_lib.h | 6 ++
> include/net/flow_dissector.h | 9 +++
> include/net/flow_offload.h | 6 ++
> include/uapi/linux/in.h | 2 +
> include/uapi/linux/l2tp.h | 2 -
> include/uapi/linux/pkt_cls.h | 2 +
> net/core/flow_dissector.c | 28 ++++++++
> net/core/flow_offload.c | 7 ++
> net/sched/cls_flower.c | 16 +++++
> 12 files changed, 179 insertions(+), 4 deletions(-)
>
>--
>2.31.1
>
next prev parent reply other threads:[~2022-08-26 11:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 11:00 [RFC PATCH net-next 0/5] ice: L2TPv3 offload support Wojciech Drewek
2022-08-26 11:00 ` [RFC PATCH net-next 1/5] uapi: move IPPROTO_L2TP to in.h Wojciech Drewek
2022-08-26 11:17 ` Jiri Pirko
2022-08-26 11:22 ` Jiri Pirko
2022-08-26 11:00 ` [RFC PATCH net-next 2/5] flow_dissector: Add L2TPv3 dissectors Wojciech Drewek
2022-08-26 11:00 ` [RFC PATCH net-next 3/5] net/sched: flower: Add L2TPv3 filter Wojciech Drewek
2022-08-26 11:00 ` [RFC PATCH net-next 4/5] flow_offload: Introduce flow_match_l2tpv3 Wojciech Drewek
2022-08-26 11:00 ` [RFC PATCH net-next 5/5] ice: Add L2TPv3 hardware offload support Wojciech Drewek
2022-08-26 11:16 ` Jiri Pirko [this message]
2022-08-26 11:36 ` [RFC PATCH net-next 0/5] ice: L2TPv3 " Drewek, Wojciech
2022-08-26 11:52 ` Drewek, Wojciech
2022-08-26 14:34 ` Jiri Pirko
2022-08-27 1:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwircDhHhOfqdHy/@nanopsycho \
--to=jiri@resnulli.us \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=baowen.zheng@corigine.com \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jchapman@katalix.com \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=komachi.yoshiki@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=louis.peens@corigine.com \
--cc=maksym.glubokiy@plvision.eu \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paulb@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=vladbu@nvidia.com \
--cc=wojciech.drewek@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox