Re: [RFC PATCH net-next 2/2] net: dcb: add new apptrust attribute

Vladimir Oltean
2022-09-12T17:16:22Z

On Mon, Sep 12, 2022 at 06:30:08PM +0200, Petr Machata wrote:
>
> <Daniel.Machon@microchip.com> writes:
>
> > Den Fri, Sep 09, 2022 at 12:29:50PM +0000 skrev Vladimir Oltean:
> >
> >> Let's say I have a switch which only looks at VLAN PCP/DEI if the bridge
> >> vlan_filtering setting is enabled (otherwise, the switch is completely
> >> VLAN unaware, including for QoS purposes).
> >>
> >> Would it be ok to report through ieee_getapptrust() that the PCP
> >> selector is trusted when under a vlan_filtering bridge, not trusted when
> >> not under a vlan_filtering bridge, and deny changes to ieee_setapptrust()
> >> for the PCP selector? I see the return value is not cached anywhere
> >> within the kernel, just passed to the user.
> >
> > Therefore, in your particular case, with the vlan_filtering on/off,
> > yes that would be OK IMO. Any concerns?
>
> Yeah, it would make sense to me. With the 802.1q bridge, the reported
> trust level would be [PCP], with 802.1d it would be [].
>
> As a service to the user, I would accept set requests that just reassert
> the only valid configuration, but otherwise it sounds OK to me.

This sounds good to me too.