From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30940C6FA82 for ; Mon, 12 Sep 2022 14:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbiILO3U (ORCPT ); Mon, 12 Sep 2022 10:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbiILO3S (ORCPT ); Mon, 12 Sep 2022 10:29:18 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9CE42E6BD; Mon, 12 Sep 2022 07:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ygBlvUkwAP2XjRoIYO5CVyjJWvpc9ks23iroQwJXaNo=; b=ThGggpTTFrROcoC91K4D4bl5Ui HGuV0/mea/MR0DmhU2j2M1Pdcftmj2mH3ZYfz9KKJVUG1dOgls0UgIqdiKDmY2mChkyz3ttaqgx6Y NGrzpwuaqQFQKsdP2phWQ70gVGVWxWEJMT2JPOzgsvs9OmGP+G+orpwSkV/O0nWOcRQvL3Uyn4q3v +7JQFajbNz4opw9n71h2Ld2VvSiisaYEyoOpqGnMhVvJIsEZ65TSt9OPm6qpMUvL7VGyfX2QtMf9p 3aExAoNvRViDloiYrd7zhJh72Od87FBcHG9oU/APBJIGGyU/ruSMZbXU/CCaTZSNE4ut6/j+1Rvuj Lk3aCTBQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34266) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oXkQv-0001mU-D2; Mon, 12 Sep 2022 15:29:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oXkQt-0008B7-8i; Mon, 12 Sep 2022 15:29:07 +0100 Date: Mon, 12 Sep 2022 15:29:07 +0100 From: "Russell King (Oracle)" To: Alvin =?utf-8?Q?=C5=A0ipraga?= Cc: Mark Kettenis , "aspriel@gmail.com" , "franky.lin@broadcom.com" , "hante.meuleman@broadcom.com" , "alyssa@rosenzweig.io" , "asahi@lists.linux.dev" , "brcm80211-dev-list.pdl@broadcom.com" , "davem@davemloft.net" , "devicetree@vger.kernel.org" , "edumazet@google.com" , "marcan@marcan.st" , "kuba@kernel.org" , "kvalo@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "pabeni@redhat.com" , "zajec5@gmail.com" , "robh+dt@kernel.org" , "SHA-cyfmac-dev-list@infineon.com" , "sven@svenpeter.dev" , "arend@broadcom.com" Subject: Re: [PATCH wireless-next v2 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Message-ID: References: <20220912115911.e7dlm2xugfq57mei@bang-olufsen.dk> <20220912142727.tmqd7h7axwo226hm@bang-olufsen.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220912142727.tmqd7h7axwo226hm@bang-olufsen.dk> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Sep 12, 2022 at 02:27:32PM +0000, Alvin Šipraga wrote: > Hi both, > > On Mon, Sep 12, 2022 at 04:13:08PM +0200, Mark Kettenis wrote: > > > Date: Mon, 12 Sep 2022 15:01:06 +0100 > > > From: "Russell King (Oracle)" > > > > > > On Mon, Sep 12, 2022 at 01:04:58PM +0100, Russell King (Oracle) wrote: > > > > On Mon, Sep 12, 2022 at 11:59:17AM +0000, Alvin Šipraga wrote: > > > > > On Mon, Sep 12, 2022 at 10:52:41AM +0100, Russell King wrote: > > > > > > From: Hector Martin > > > > > > > > > > > > This binding is currently used for SDIO devices, but these chips are > > > > > > also used as PCIe devices on DT platforms and may be represented in the > > > > > > DT. Re-use the existing binding and add chip compatibles used by Apple > > > > > > T2 and M1 platforms (the T2 ones are not known to be used in DT > > > > > > platforms, but we might as well document them). > > > > > > > > > > > > Then, add properties required for firmware selection and calibration on > > > > > > M1 machines. > > > > > > > > > > > > Reviewed-by: Linus Walleij > > > > > > Signed-off-by: Hector Martin > > > > > > Reviewed-by: Mark Kettenis > > > > > > Reviewed-by: Rob Herring > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > --- > > > > > > .../net/wireless/brcm,bcm4329-fmac.yaml | 39 +++++++++++++++++-- > > > > > > 1 file changed, 35 insertions(+), 4 deletions(-) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > > > > > index 53b4153d9bfc..fec1cc9b9a08 100644 > > > > > > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > > > > > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > > > > > @@ -4,7 +4,7 @@ > > > > > > $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml > > > > > > $schema: http://devicetree.org/meta-schemas/core.yaml > > > > > > > > > > > > -title: Broadcom BCM4329 family fullmac wireless SDIO devices > > > > > > +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices > > > > > > > > > > > > maintainers: > > > > > > - Arend van Spriel > > > > > > @@ -41,11 +41,17 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices > > > > > > - cypress,cyw4373-fmac > > > > > > - cypress,cyw43012-fmac > > > > > > - const: brcm,bcm4329-fmac > > > > > > - - const: brcm,bcm4329-fmac > > > > > > + - enum: > > > > > > + - brcm,bcm4329-fmac > > > > > > + - pci14e4,43dc # BCM4355 > > > > > > + - pci14e4,4464 # BCM4364 > > > > > > + - pci14e4,4488 # BCM4377 > > > > > > + - pci14e4,4425 # BCM4378 > > > > > > + - pci14e4,4433 # BCM4387 > > > > > > > > > > > > reg: > > > > > > - description: SDIO function number for the device, for most cases > > > > > > - this will be 1. > > > > > > + description: SDIO function number for the device (for most cases > > > > > > + this will be 1) or PCI device identifier. > > > > > > > > > > > > interrupts: > > > > > > maxItems: 1 > > > > > > @@ -85,6 +91,31 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices > > > > > > takes precedence. > > > > > > type: boolean > > > > > > > > > > > > + brcm,cal-blob: > > > > > > + $ref: /schemas/types.yaml#/definitions/uint8-array > > > > > > + description: A per-device calibration blob for the Wi-Fi radio. This > > > > > > + should be filled in by the bootloader from platform configuration > > > > > > + data, if necessary, and will be uploaded to the device if present. > > > > > > > > > > Is this a leftover from a previous revision of the patchset? Because as > > > > > far as I can tell, the CLM blob is (still) being loaded via firmware, > > > > > and no additional parsing has been added for this particular OF > > > > > property. Should it be dropped? > > > > > > > > It does appear to be unparsed, but I don't know whether it's needed for > > > > the binding or not. I'll wait for the Asahi folk to review your comment > > > > before possibly removing it. > > > > > > Okay, the answer is, it is still very much part of the binding, and > > > the m1n1 boot loader populates it. > > > > > > This series is a subset of a larger series (remember the previous 34 > > > or 35 patch series?), so there are things in the binding document > > > which are not included in this series. > > > > > > I don't think it makes sense to break up the binding document given > > > that it has already been reviewed several times in its current state, > > > should we really remove this one property and throw away all that > > > review effort. > > > > The OpenBSD driver already uses these properties. So even if the > > Linux driver doesn't use this yet, there is an existing implementation > > that does. That should be good enough for it to be included in the > > binding isn't it? > > Yes, I suspected that might be the case too. I think it's fine. > > Thanks Russel for the clarification btw. Feel free to add my > > Reviewed-by: Alvin Šipraga Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!