From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C45BC001B5 for ; Fri, 2 Sep 2022 16:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237694AbiIBQJb (ORCPT ); Fri, 2 Sep 2022 12:09:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237137AbiIBQJC (ORCPT ); Fri, 2 Sep 2022 12:09:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F25D7C3F5B for ; Fri, 2 Sep 2022 09:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662134486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SgHJl1w30qXGPLJjsRfodiLaezwna9ogLkShAQBO/0Q=; b=dSwhDSbKzWCV99+rA2yqZL0alXZRwDZa1ac4zR9YblLQ5f5dOPRbprW1wSqIIo1PjtH6z5 05iDabwGEzU5KEkNJQQH9Ty9Tm20nE1HEfwa/sf5r09xADeTQ8MEtpfULAdmO8HX0fYhqt /x8cGX2rhD7mCOUg5cQUbKI5/nY6fWk= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-503-Ls9VmFAmOOGL15GGWoq0oA-1; Fri, 02 Sep 2022 12:01:24 -0400 X-MC-Unique: Ls9VmFAmOOGL15GGWoq0oA-1 Received: by mail-ej1-f72.google.com with SMTP id qk37-20020a1709077fa500b00730c2d975a0so1226140ejc.13 for ; Fri, 02 Sep 2022 09:01:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=SgHJl1w30qXGPLJjsRfodiLaezwna9ogLkShAQBO/0Q=; b=KeKnk2IA5TEE/XEdI/JGW+5dBofbv48O/n02+55tUlB7rM6Bg5YM95Qag5Sqw3JZdW R6T8YjUj7dUPoTn0cQwzpwf35lmDjaM5c/KtT+upPAgROrTzgx3RHArDs75P3IzwdAA2 Ja8RAJcC+p41kITl0zC/rf0qI9tAtoBg2ZUxs0cPDKJDWQNb3bQtuXuDdd0w9wxtRyax W5dZVIYF1vWq0sChTOk+WI3xyp0xhC8+ZKgoen0W+NUYd1dxnLTZ7dUBqoBQElqqkh7I 7b64H0A3E6vC/lAdbZ2Vh/SvXoPQx4TCTrI4G7wcAH5LeSw8Km1OlpXcl/Wkn6F3fAlD z83Q== X-Gm-Message-State: ACgBeo0QRGkyB/tPYwsOVq1RQQC4/pVZw+4xRo6s0/I22JrYXXHSwwEz yLa90/uQ7Znkqz7Lz1eZ6TX6bNl+le3Mh7OfwQrGUZM/vEuFF00LrgtuZafuARwqYqKStylWxnG uiMCOohGOFuXx/OWy X-Received: by 2002:a17:906:cc5d:b0:741:38a8:a50a with SMTP id mm29-20020a170906cc5d00b0074138a8a50amr22564454ejb.650.1662134483320; Fri, 02 Sep 2022 09:01:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR4aXddeqj3eWlfmKtGE0FV/hQh7Xo7rnOr/ynEFGCa9cz/OWQAGbaqljgEGqCoZ+QVC64Rsew== X-Received: by 2002:a17:906:cc5d:b0:741:38a8:a50a with SMTP id mm29-20020a170906cc5d00b0074138a8a50amr22564429ejb.650.1662134483058; Fri, 02 Sep 2022 09:01:23 -0700 (PDT) Received: from localhost (net-93-71-3-16.cust.vodafonedsl.it. [93.71.3.16]) by smtp.gmail.com with ESMTPSA id 1-20020a170906218100b0073a644ef803sm1464635eju.101.2022.09.02.09.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 09:01:22 -0700 (PDT) Date: Fri, 2 Sep 2022 18:01:20 +0200 From: Lorenzo Bianconi To: Daniel =?iso-8859-1?Q?M=FCller?= Cc: Daniel Borkmann , Lorenzo Bianconi , bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org, andrii@kernel.org, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, pablo@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org, brouer@redhat.com, toke@redhat.com, memxor@gmail.com Subject: Re: [PATCH bpf-next 0/4] Introduce bpf_ct_set_nat_info kfunc helper Message-ID: References: <20220902154420.wpox77fwlamul444@nuc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Tlrij5E7duojB1Rs" Content-Disposition: inline In-Reply-To: <20220902154420.wpox77fwlamul444@nuc> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --Tlrij5E7duojB1Rs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Fri, Sep 02, 2022 at 04:41:28PM +0200, Daniel Borkmann wrote: > > On 9/2/22 4:35 PM, Lorenzo Bianconi wrote: > > > On Sep 02, Daniel Borkmann wrote: > > > > On 9/1/22 6:43 PM, Lorenzo Bianconi wrote: > > > > > Introduce bpf_ct_set_nat_info kfunc helper in order to set source= and > > > > > destination nat addresses/ports in a new allocated ct entry not i= nserted > > > > > in the connection tracking table yet. > > > > > Introduce support for per-parameter trusted args. > > > > >=20 > > > > > Kumar Kartikeya Dwivedi (2): > > > > > bpf: Add support for per-parameter trusted args > > > > > selftests/bpf: Extend KF_TRUSTED_ARGS test for __ref annotati= on > > > > >=20 > > > > > Lorenzo Bianconi (2): > > > > > net: netfilter: add bpf_ct_set_nat_info kfunc helper > > > > > selftests/bpf: add tests for bpf_ct_set_nat_info kfunc > > > > >=20 > > > > > Documentation/bpf/kfuncs.rst | 18 +++++++ > > > > > kernel/bpf/btf.c | 39 ++++++++++-= ---- > > > > > net/bpf/test_run.c | 9 +++- > > > > > net/netfilter/nf_conntrack_bpf.c | 49 +++++++++++= +++++++- > > > > > .../testing/selftests/bpf/prog_tests/bpf_nf.c | 2 + > > > > > .../testing/selftests/bpf/progs/test_bpf_nf.c | 26 +++++++++- > > > > > tools/testing/selftests/bpf/verifier/calls.c | 38 +++++++++++= --- > > > > > 7 files changed, 156 insertions(+), 25 deletions(-) > > > > >=20 > > > >=20 > > > > Looks like this fails BPF CI, ptal: > > > >=20 > > > > https://github.com/kernel-patches/bpf/runs/8147936670?check_suite_f= ocus=3Dtrue > > >=20 > > > Hi Daniel, > > >=20 > > > it seems CONFIG_NF_NAT is not set in the kernel config file. > > > Am I supposed to enable it in bpf-next/tools/testing/selftests/bpf/co= nfig? > >=20 > > This would have to be set there and added to the patches, yes. @Andrii/= DanielM, is > > this enough or are other steps needed on top of that? >=20 > Yes, I think it should be set at said location. Nothing else should be > needed in addition that I can think of. ack, I will wait a bit for some more feedbacks and then I will post v2. Regards, Lorenzo >=20 > Thanks, > Daniel >=20 > [...] >=20 --Tlrij5E7duojB1Rs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYxIo0AAKCRA6cBh0uS2t rIbZAQCj8I7wj7VpXQ+MtZxUeYwUL5FahOtLqn7oN6s5fEWFyAEAx41hI9kY/c5v ILpn9IjIxu/xIMkJtMxuytiEmuOKBg8= =cGkM -----END PGP SIGNATURE----- --Tlrij5E7duojB1Rs--