From: Cong Wang <xiyou.wangcong@gmail.com>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jhs@mojatatu.com, jiri@resnulli.us,
vladbu@mellanox.com, weiyongjun1@huawei.com,
yuehaibing@huawei.com
Subject: Re: [PATCH net,v2] net: sched: tbf: don't call qdisc_put() while holding tree lock
Date: Mon, 5 Sep 2022 11:13:34 -0700 [thread overview]
Message-ID: <YxY8ToCVWFSV6VqQ@pop-os.localdomain> (raw)
In-Reply-To: <20220826013930.340121-1-shaozhengchao@huawei.com>
On Fri, Aug 26, 2022 at 09:39:30AM +0800, Zhengchao Shao wrote:
> The issue is the same to commit c2999f7fb05b ("net: sched: multiq: don't
> call qdisc_put() while holding tree lock"). Qdiscs call qdisc_put() while
> holding sch tree spinlock, which results sleeping-while-atomic BUG.
>
Hm, did you see an actual warning here??
The commit you mentioned above is a classful Qdisc which accepts
user-specified child Qdisc, but TBF technically does not, I don't think
you can change its default fifo.
Thanks.
next prev parent reply other threads:[~2022-09-05 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 1:39 [PATCH net,v2] net: sched: tbf: don't call qdisc_put() while holding tree lock Zhengchao Shao
2022-08-30 10:00 ` patchwork-bot+netdevbpf
2022-09-05 18:13 ` Cong Wang [this message]
2022-09-07 1:24 ` shaozhengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxY8ToCVWFSV6VqQ@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=vladbu@mellanox.com \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).