From: Andrew Lunn <andrew@lunn.ch>
To: Sergei Antonov <saproj@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next] net: ftmac100: fix endianness-related issues from 'sparse'
Date: Tue, 6 Sep 2022 02:25:16 +0200 [thread overview]
Message-ID: <YxaTbDoCOA1+23zP@lunn.ch> (raw)
In-Reply-To: <20220902113749.1408562-1-saproj@gmail.com>
On Fri, Sep 02, 2022 at 02:37:49PM +0300, Sergei Antonov wrote:
> Sparse found a number of endianness-related issues of these kinds:
>
> .../ftmac100.c:192:32: warning: restricted __le32 degrades to integer
>
> .../ftmac100.c:208:23: warning: incorrect type in assignment (different base types)
> .../ftmac100.c:208:23: expected unsigned int rxdes0
> .../ftmac100.c:208:23: got restricted __le32 [usertype]
>
> .../ftmac100.c:249:23: warning: invalid assignment: &=
> .../ftmac100.c:249:23: left side has type unsigned int
> .../ftmac100.c:249:23: right side has type restricted __le32
>
> .../ftmac100.c:527:16: warning: cast to restricted __le32
>
> Change type of some fields from 'unsigned int' to '__le32' to fix it.
>
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-09-06 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 11:37 [PATCH net-next] net: ftmac100: fix endianness-related issues from 'sparse' Sergei Antonov
2022-09-06 0:25 ` Andrew Lunn [this message]
2022-09-06 8:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxaTbDoCOA1+23zP@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saproj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).