From: Andrew Lunn <andrew@lunn.ch>
To: Mattias Forsblad <mattias.forsblad@gmail.com>
Cc: netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v4 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches.
Date: Tue, 6 Sep 2022 14:29:38 +0200 [thread overview]
Message-ID: <Yxc9MjVI+afjcNcp@lunn.ch> (raw)
In-Reply-To: <20220906063450.3698671-2-mattias.forsblad@gmail.com>
> +int mv88e6085_g1_rmu_enable(struct mv88e6xxx_chip *chip, int upstream_port)
> +{
> + int val = MV88E6352_G1_CTL2_RMU_MODE_DISABLED;
> +
> + dev_dbg(chip->dev, "RMU: Enabling on port %d", upstream_port);
> +
> + switch (upstream_port) {
>
> +int mv88e6352_g1_rmu_enable(struct mv88e6xxx_chip *chip, int port)
> +{
> + int val = MV88E6352_G1_CTL2_RMU_MODE_DISABLED;
> + int upstream_port;
> +
> + upstream_port = dsa_switch_upstream_port(chip->ds);
> + dev_dbg(chip->dev, "RMU: Enabling on port %d", upstream_port);
> + if (upstream_port < 0)
> + return -EOPNOTSUPP;
> +
> + switch (upstream_port) {
> +int mv88e6390_g1_rmu_enable(struct mv88e6xxx_chip *chip, int upstream_port)
> +{
> + int val = MV88E6390_G1_CTL2_RMU_MODE_DISABLED;
> +
> + dev_dbg(chip->dev, "RMU: Enabling on port %d", upstream_port);
> +
> + switch (upstream_port) {
Why is 6352 different to 6085 and 6390? This is the sort of thing
which should be explained in the commit message. The commit message is
about the 'Why?' of the change. You could explain why there is this
difference, so a reviewer does not need to ask.
Andrew
next prev parent reply other threads:[~2022-09-06 12:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 6:34 [PATCH net-next v4 0/6] net: dsa: mv88e6xxx: qca8k: rmon: Add RMU support Mattias Forsblad
2022-09-06 6:34 ` [PATCH net-next v4 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches Mattias Forsblad
2022-09-06 12:29 ` Andrew Lunn [this message]
2022-09-07 5:55 ` Mattias Forsblad
2022-09-06 21:46 ` Florian Fainelli
2022-09-07 6:29 ` Mattias Forsblad
2022-09-06 6:34 ` [PATCH net-next v4 2/6] net: dsa: Add convenience functions for frame handling Mattias Forsblad
2022-09-06 12:43 ` Andrew Lunn
2022-09-07 6:19 ` Mattias Forsblad
2022-09-06 21:44 ` Florian Fainelli
2022-09-08 11:32 ` Paolo Abeni
2022-09-06 6:34 ` [PATCH net-next v4 3/6] net: dsa: Introduce dsa tagger data operation Mattias Forsblad
2022-09-06 13:08 ` Andrew Lunn
2022-09-06 13:51 ` Vladimir Oltean
2022-09-06 6:34 ` [PATCH net-next v4 4/6] net: dsa: mv88e6xxxx: Add RMU functionality Mattias Forsblad
2022-09-06 6:34 ` [PATCH net-next v4 5/6] net: dsa: mv88e6xxx: rmon: Use RMU for reading RMON data Mattias Forsblad
2022-09-06 6:34 ` [PATCH net-next v4 6/6] net: dsa: qca8k: Use new convenience functions Mattias Forsblad
2022-09-06 8:07 ` [PATCH net-next v4 0/6] net: dsa: mv88e6xxx: qca8k: rmon: Add RMU support Marek Behún
2022-09-06 9:45 ` Mattias Forsblad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxc9MjVI+afjcNcp@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=mattias.forsblad@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).