public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: <Daniel.Machon@microchip.com>
To: <vladimir.oltean@nxp.com>
Cc: <Allan.Nielsen@microchip.com>, <kuba@kernel.org>,
	<petrm@nvidia.com>, <netdev@vger.kernel.org>,
	<vinicius.gomes@intel.com>, <thomas.petazzoni@bootlin.com>,
	<maxime.chevallier@bootlin.com>, <roopa@nvidia.com>
Subject: Re: Basic PCP/DEI-based queue classification
Date: Wed, 7 Sep 2022 10:41:10 +0000	[thread overview]
Message-ID: <Yxh3ZOvfESYT36UN@DEN-LT-70577> (raw)
In-Reply-To: <20220902133218.bgfd2uaelvn6dsfa@skbuf>

> > I think this feature belong in DCB simply because DCB already have the
> > related configurations (like the default prio, priority-flow-control
> > etc), and it will be more logical for the user to find the PCP mapping
> > in the same place.
> >
> > I think that framepreemption should be in ethtool as it is partly
> > defined in IEEE802.3 (the physical layer) and it is ethernet only
> > technology.
> >
> > /Allan
> 
> My explanation given to Jakub at the time was that I don't quite
> understand what should belong to dcbnl and what shouldn't.
> https://lore.kernel.org/netdev/20220523224943.75oyvbxmyp2kjiwi@skbuf/
> 
> From my perspective it's an inconvenience that dcbnl exists as a
> separate kernel subsystem and isn't converged with the ethtool
> genetlink.
> 
> Regarding the topic at hand, and the apparent lack of PCP-based
> prioritization in the software data path. VLAN devices have an
> ingress-qos-map and an egress-qos-map. How would prioritization done via
> dcbnl interact with those (who would take precedence)?

Hi Vladimir,

They shouldn't interact (at least this is my understanding). 

The ingress and egress maps are for vlan interfaces, and dcb operates
on physical interfaces (dcbx too). You cannot use dcbnl to do
prioritization for vlan interfaces.

Anyway, I think much of the stuff in DCB is for hw offload only, incl. the
topic at hand. Is the APP table even consulted by the sw stack at all - I
dont think so (apart from drivers).

/ Daniel

  reply	other threads:[~2022-09-07 10:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  9:09 Basic PCP/DEI-based queue classification Daniel.Machon
2022-08-19 10:50 ` Petr Machata
2022-08-21 20:58   ` Daniel.Machon
2022-08-22 10:34     ` Petr Machata
2022-08-24  7:39       ` Daniel.Machon
2022-08-24  9:45         ` Petr Machata
2022-08-24 17:55           ` Daniel.Machon
2022-08-24 19:36             ` Petr Machata
2022-08-25  0:54               ` Jakub Kicinski
2022-08-26 18:11                 ` Petr Machata
2022-08-29  7:53                 ` Allan W. Nielsen
2022-09-02 13:32                   ` Vladimir Oltean
2022-09-07 10:41                     ` Daniel.Machon [this message]
2022-09-07 17:26                       ` Vladimir Oltean
2022-09-07 19:57                         ` Daniel.Machon
2022-09-08  8:03                           ` Allan Nielsen - M31684
2022-09-08 11:18                           ` Petr Machata
2022-09-08 12:01                             ` Daniel.Machon
2022-09-09 12:11                           ` Vladimir Oltean
2022-09-08  8:27                         ` Petr Machata
2022-08-25 11:31               ` Daniel.Machon
2022-08-25 13:30                 ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yxh3ZOvfESYT36UN@DEN-LT-70577 \
    --to=daniel.machon@microchip.com \
    --cc=Allan.Nielsen@microchip.com \
    --cc=kuba@kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@nvidia.com \
    --cc=roopa@nvidia.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vinicius.gomes@intel.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox