From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DCEC54EE9 for ; Wed, 7 Sep 2022 18:06:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbiIGSGv (ORCPT ); Wed, 7 Sep 2022 14:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbiIGSGg (ORCPT ); Wed, 7 Sep 2022 14:06:36 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1F1FC04F4; Wed, 7 Sep 2022 11:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8PtQ4Fkejr4eJpoCDQbF8C/kbVNVUFlTeC1eJX0hAeY=; b=SkVuvezfgAOGNcPIoMvzxq8zGw 0rYUrmEIcV//huhoPWbvObDTEsYuhP27HkJQXYY0e7Gq+avcj1ACElVJkEU56xvmnyC2OiCzrtUDd RK/ubwehnwVrmlsHbsptd6VEW+18GUqbeh8RPKjB09xWvWBFb30Z09OBMJcB5XdWehgEAy+4l8h+S a+JHBzIO4s1s300Zwo+rDygdjxU5jC6HIEDEE8g1I70d5/7+sLNCgTGSgp0hxtHBQHyv9Or/lLQNi 2RWZK3TShuZnmMMHF5nPVCT9p9+rbqMt8z/QvHsOYKGxbJyjN2BAdWhChb8wEl6cBwtA2+uorrRAp lSeF1a5A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34192) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oVzRY-0005iO-UC; Wed, 07 Sep 2022 19:06:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oVzRY-0001I9-8U; Wed, 07 Sep 2022 19:06:32 +0100 Date: Wed, 7 Sep 2022 19:06:32 +0100 From: "Russell King (Oracle)" To: Sean Anderson Cc: netdev@vger.kernel.org, Andrew Lunn , Heiner Kallweit , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Alexandru Marginean , linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet Subject: Re: [PATCH net-next v5 5/8] net: phylink: Adjust link settings based on rate adaptation Message-ID: References: <20220906161852.1538270-1-sean.anderson@seco.com> <20220906161852.1538270-6-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 07, 2022 at 01:01:49PM -0400, Sean Anderson wrote: > > > if (pl->pcs && pl->pcs->ops->pcs_link_up) > > > pl->pcs->ops->pcs_link_up(pl->pcs, pl->cur_link_an_mode, > > > - pl->cur_interface, > > > - link_state.speed, link_state.duplex); > > > + pl->cur_interface, speed, duplex); > > > > It seems you have one extra unnecessary space here - not sure how > > that occurred as it isn't in my original patch. > > > > This corrects a spacing issue in the existing code. Okay, I agree. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!