From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0D0D4ECAAD3
	for <netdev@archiver.kernel.org>; Fri,  9 Sep 2022 10:19:45 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230098AbiIIKTm (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 9 Sep 2022 06:19:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47288 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229824AbiIIKTk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 9 Sep 2022 06:19:40 -0400
Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 492AD101D2
        for <netdev@vger.kernel.org>; Fri,  9 Sep 2022 03:19:32 -0700 (PDT)
Date:   Fri, 9 Sep 2022 12:19:28 +0200
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Florian Westphal <fw@strlen.de>
Cc:     Chris Clayton <chris2553@googlemail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: b118509076b3 (probably) breaks my firewall
Message-ID: <YxsTMMFoaNSM9gLN@salvia>
References: <e5d757d7-69bc-a92a-9d19-0f7ed0a81743@googlemail.com>
 <20220908191925.GB16543@breakpoint.cc>
 <78611fbd-434e-c948-5677-a0bdb66f31a5@googlemail.com>
 <20220908214859.GD16543@breakpoint.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220908214859.GD16543@breakpoint.cc>
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, Sep 08, 2022 at 11:48:59PM +0200, Florian Westphal wrote:
> Chris Clayton <chris2553@googlemail.com> wrote:
> 
> [ CC Pablo ]
> 
> > On 08/09/2022 20:19, Florian Westphal wrote:
> > > Chris Clayton <chris2553@googlemail.com> wrote:
> > >> Just a heads up and a question...
> > >>
> > >> I've pulled the latest and greatest from Linus' tree and built and installed the kernel. git describe gives
> > >> v6.0-rc4-126-g26b1224903b3.
> > >>
> > >> I find that my firewall is broken because /proc/sys/net/netfilter/nf_conntrack_helper no longer exists. It existed on an
> > >> -rc4 kernel. Are changes like this supposed to be introduced at this stage of the -rc cycle?
> > > 
> > > The problem is that the default-autoassign (nf_conntrack_helper=1) has
> > > side effects that most people are not aware of.
> > > 
> > > The bug that propmpted this toggle from getting axed was that the irc (dcc) helper allowed
> > > a remote client to create a port forwarding to the local client.
> > 
> > 
> > Ok, but I still think it's not the sort of change that should be introduced at this stage of the -rc cycle.
> > The other problem is that the documentation (Documentation/networking/nf_conntrack-sysctl.rst) hasn't been updated. So I
> > know my firewall is broken but there's nothing I can find that tells me how to fix it.
> 
> Pablo, I don't think revert+move the 'next' will avoid this kinds of
> problems, but at least the nf_conntrack-sysctl.rst should be amended to
> reflect that this was removed.

I'll post a patch to amend the documentation.

> I'd keep it though because people that see an error wrt. this might be
> looking at nf_conntrack-sysctl.rst.
> 
> Maybe just a link to
> https://home.regit.org/netfilter-en/secure-use-of-helpers/?
> 
> What do you think?

I'll update netfilter.org to host a copy of the github sources.

We have been announcing this going deprecated for 10 years...