From: Hangbin Liu <liuhangbin@gmail.com>
To: David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
Guillaume Nault <gnault@redhat.com>
Subject: Re: [PATCH iproute2-next 1/1] ip: add NLM_F_ECHO support
Date: Fri, 23 Sep 2022 12:15:26 +0800 [thread overview]
Message-ID: <Yy0y3qIS1rLGt3s1@Laptop-X1> (raw)
In-Reply-To: <fba2ec25-d15c-8c1a-32f8-d20d81c1f1cb@kernel.org>
On Thu, Sep 22, 2022 at 04:17:08PM -0700, David Ahern wrote:
> > + if (echo_request)
> > + req.n.nlmsg_flags |= NLM_F_ECHO|NLM_F_ACK;
>
> fixed the spacing on the flags (all locations) and applied to iproute2-next.
Thanks for the fixing!
> >
> > + if (echo_request) {
> > + new_json_obj(json);
> > + open_json_object(NULL);
> > + print_addrinfo(answer, stdout);
> > + close_json_object();
> > + delete_json_obj();
> > + free(answer);
> > + }
>
> That list is redundant. I think it can be turned into a util function
> that takes an the print function as an input argument.
I will post a patch to remove the redundant code.
Hangbin
prev parent reply other threads:[~2022-09-23 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 3:34 [PATCH iproute2-next 0/1] ip: add NLM_F_ECHO support Hangbin Liu
2022-09-16 3:34 ` [PATCH iproute2-next 1/1] " Hangbin Liu
2022-09-22 23:17 ` David Ahern
2022-09-23 4:15 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy0y3qIS1rLGt3s1@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=dsahern@kernel.org \
--cc=gnault@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox