From: Hangbin Liu <liuhangbin@gmail.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Shuah Khan <shuah@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] selftests/bonding: re-add lladdr target test
Date: Fri, 23 Sep 2022 17:21:53 +0800 [thread overview]
Message-ID: <Yy16saDPo5tnkXdp@Laptop-X1> (raw)
In-Reply-To: <20220923082306.2468081-1-matthieu.baerts@tessares.net>
On Fri, Sep 23, 2022 at 10:23:06AM +0200, Matthieu Baerts wrote:
> It looks like this test has been accidentally dropped when resolving
> conflicts in this Makefile.
>
> Most probably because there were 3 different patches modifying this file
> in parallel:
>
> commit 152e8ec77640 ("selftests/bonding: add a test for bonding lladdr target")
> commit bbb774d921e2 ("net: Add tests for bonding and team address list management")
> commit 2ffd57327ff1 ("selftests: bonding: cause oops in bond_rr_gen_slave_id")
>
> The first one was applied in 'net-next' while the two other ones were
> recently applied in the 'net' tree.
Thanks for the fix. Before re-post to net-next, I should wait for some more
time so lladdr test could be applied to net tree.
Hangbin
>
> But that's alright, easy to fix by re-adding the missing one!
>
> Fixes: 0140a7168f8b ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
> tools/testing/selftests/drivers/net/bonding/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/Makefile b/tools/testing/selftests/drivers/net/bonding/Makefile
> index d14846fcf3d1..e9dab5f9d773 100644
> --- a/tools/testing/selftests/drivers/net/bonding/Makefile
> +++ b/tools/testing/selftests/drivers/net/bonding/Makefile
> @@ -4,6 +4,7 @@
> TEST_PROGS := \
> bond-arp-interval-causes-panic.sh \
> bond-break-lacpdu-tx.sh \
> + bond-lladdr-target.sh \
> dev_addr_lists.sh
>
> TEST_FILES := lag_lib.sh
>
> base-commit: d05d9eb79d0cd0f7a978621b4a56a1f2db444f86
> --
> 2.37.2
>
next prev parent reply other threads:[~2022-09-23 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 8:23 [PATCH net-next] selftests/bonding: re-add lladdr target test Matthieu Baerts
2022-09-23 9:21 ` Hangbin Liu [this message]
2022-09-23 13:25 ` Jakub Kicinski
2022-09-23 14:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy16saDPo5tnkXdp@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).