From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAE7C6FA82 for ; Tue, 13 Sep 2022 19:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbiIMTDJ (ORCPT ); Tue, 13 Sep 2022 15:03:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232481AbiIMTCm (ORCPT ); Tue, 13 Sep 2022 15:02:42 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A062384; Tue, 13 Sep 2022 12:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RK8HL1F3M1TdUKlkjzvVy3Mv1UGK5lskuBgs4dh2sRI=; b=0kyX9qxPF6heEV9PGyQXRhz4zt jwinzSE2M7041xLdAS2rgVJw+mXQcalx+8X+vy2yNXMP6rRZxotRtycGoEHhC6Ba68FGMoQUt6qZC 0u8SOQuuq0OfoTNYyUm7zVaWihqfS4Mvwd8x5nywwqa7q6f9QRQesOwW8opQX+ZMfBcOjcLjgHRuh kBc3kbad56Ghn0c6fDUU7If1d9UkgFWuQC8acDoRBDJwi4LyjgOVyyBzhOY6yvGKRX48otdLgiHAi p2DZK+w+B1/dOH1QzDgo6GPuqzUSTlAYbhbGfbV0RWi61ehoV03wageHLD5Gs+Z4/NGCgf4RdpfB9 b4E64dHA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34304) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oYBAK-0003QE-5E; Tue, 13 Sep 2022 20:01:48 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oYBAJ-0000uI-Dm; Tue, 13 Sep 2022 20:01:47 +0100 Date: Tue, 13 Sep 2022 20:01:47 +0100 From: "Russell King (Oracle)" To: Oleksandr Mazur Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, hkallweit1@gmail.com, andrew@lunn.ch Subject: Re: [PATCH 2/2] net: sfp: add quirk for FINISAR FTLF8536P4BCL SFP module Message-ID: References: <20220913181009.13693-1-oleksandr.mazur@plvision.eu> <20220913181009.13693-3-oleksandr.mazur@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913181009.13693-3-oleksandr.mazur@plvision.eu> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 13, 2022 at 09:10:09PM +0300, Oleksandr Mazur wrote: > The FINISAR FTLF8536P4BCL reports 25G & 100GBd SR in it's EEPROM, > but supports only 1000base-X and 10000base-SR modes. > > Add quirk to clear unsupported modes, and set only the ones that > module actually supports: 1000base-X and 10000base-SR. This description does not match what the patch is doing. I see no modes being cleared. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!