From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79F0ECAAD3 for ; Wed, 14 Sep 2022 12:07:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbiINMHE (ORCPT ); Wed, 14 Sep 2022 08:07:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbiINMHC (ORCPT ); Wed, 14 Sep 2022 08:07:02 -0400 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABF057F257; Wed, 14 Sep 2022 05:07:00 -0700 (PDT) Received: by mail-qv1-xf2d.google.com with SMTP id s13so11500450qvq.10; Wed, 14 Sep 2022 05:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=2seAi8p9cHTQ5grUkwewK+XdzcnHWiXhnN5EOp8ed1M=; b=dwVpg4cqBY0+c9XrNnlYb7uyYW8DoeEJtl5JT2pRFd16SN6bHT7Cl20p6HTwD8cR4P +3DmJ/tjHNIGlq4usUb/aMaDOZtRKeAhnuZMJLSB84JCtPLk9K+ExSEhWd6pV/K9j9hF QX/nqvHMFBz0rT8Wfbc3hwvmjwEziEvweO1XoqmVAD2tLonoTF+3w5kIQ0x7OKVJrihv lwS27Tjndm+nR7G3gp4DZJpFqKVI2fpWuvk9N1JVrHDjB9pwD+0HSQwu1IP4RFtLCohW jer/4LYVGMXOHKdtpsDCCOHTgo4LZVl3dAYiZNgR+c7GA/Ek2rYIReSwvmTObibAySzv VFfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=2seAi8p9cHTQ5grUkwewK+XdzcnHWiXhnN5EOp8ed1M=; b=lxE1mF6muEG7B3X2PsylvCQMyruwPkJL7Eq+PSriDiPXi2TXpkl9DFXnX1bJRLExMN vEuJFnlY6HcU8q48djGG+Oz8u1G95beS9GRvyQSlAo9gRzmI4tWuV4k2+3IyWZr+bAyB pZ18H2V87drbF4BUKj4R0fcy0Xk1myvOlKaQBiXSuku7/hl4xaTNKnWG4PLw/dVNMIyX hy/1NNpkS/01dpNGjGaG36RFbr79HWTw71K1Mk2r4G7yROK06oC60eoQjO3kBsxi3nyP rj4rl+FALY27CIhZVsFN6Q4O/kzpn/+OHaNVZhY+UMsFbAxtpWMKpudGVmQUg5j7qjqG xcVg== X-Gm-Message-State: ACgBeo0dPrzvuHH9dwoP0cjvfatt7tAPdkyZyTpH+ps9FnuU84ej8j1/ lQnqbJhoIiiQDZmJaIEV8tsun1CFPAbv5Q== X-Google-Smtp-Source: AA6agR4qM8+4xZ8JfYFrFjrKKP+AQwRkgUoluvJ40CPzqYuFfl1kgsgy8xlZMg6+Rjj/AkbVhMNsOA== X-Received: by 2002:a0c:e152:0:b0:4ac:8080:215c with SMTP id c18-20020a0ce152000000b004ac8080215cmr24791308qvl.2.1663157219360; Wed, 14 Sep 2022 05:06:59 -0700 (PDT) Received: from errol.ini.cmu.edu (pool-72-77-81-136.pitbpa.fios.verizon.net. [72.77.81.136]) by smtp.gmail.com with ESMTPSA id i10-20020ac84f4a000000b0031eb5648b86sm1452330qtw.41.2022.09.14.05.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 05:06:58 -0700 (PDT) Date: Wed, 14 Sep 2022 08:06:56 -0400 From: "Gabriel L. Somlo" To: Nathan Chancellor Cc: Nathan Huckleberry , Dan Carpenter , llvm@lists.linux.dev, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Karol Gugala , Mateusz Holenko , Joel Stanley , Nick Desaulniers , Tom Rix , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: litex: Fix return type of liteeth_start_xmit Message-ID: References: <20220912195307.812229-1-nhuck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 13, 2022 at 03:31:11PM -0700, Nathan Chancellor wrote: > On Mon, Sep 12, 2022 at 12:53:07PM -0700, Nathan Huckleberry wrote: > > The ndo_start_xmit field in net_device_ops is expected to be of type > > netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev). > > > > The mismatched return type breaks forward edge kCFI since the underlying > > function definition does not match the function hook definition. > > > > The return type of liteeth_start_xmit should be changed from int to > > netdev_tx_t. > > > > Reported-by: Dan Carpenter > > Link: https://github.com/ClangBuiltLinux/linux/issues/1703 > > Cc: llvm@lists.linux.dev > > Signed-off-by: Nathan Huckleberry > > Reviewed-by: Nathan Chancellor Acked-by: Gabriel Somlo Thanks, --G > > --- > > drivers/net/ethernet/litex/litex_liteeth.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c > > index fdd99f0de424..35f24e0f0934 100644 > > --- a/drivers/net/ethernet/litex/litex_liteeth.c > > +++ b/drivers/net/ethernet/litex/litex_liteeth.c > > @@ -152,7 +152,8 @@ static int liteeth_stop(struct net_device *netdev) > > return 0; > > } > > > > -static int liteeth_start_xmit(struct sk_buff *skb, struct net_device *netdev) > > +static netdev_tx_t liteeth_start_xmit(struct sk_buff *skb, > > + struct net_device *netdev) > > { > > struct liteeth *priv = netdev_priv(netdev); > > void __iomem *txbuffer; > > -- > > 2.37.2.789.g6183377224-goog > >