Netdev List
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
	<linux-hwmon@vger.kernel.org>,
	Alexander Duyck <alexander.duyck@gmail.com>,
	Gurucharan <gurucharanx.g@intel.com>
Subject: Re: [RESEND PATCH] ixgbe: Don't call kmap() on page allocated with GFP_ATOMIC
Date: Thu, 15 Sep 2022 09:58:33 -0700	[thread overview]
Message-ID: <YyNZuTlShCviTKXi@iweiny-desk3> (raw)
In-Reply-To: <96855b74-5b77-4426-891b-d638ead17cd6@intel.com>

On Thu, Sep 15, 2022 at 09:30:50AM -0700, Tony Nguyen wrote:
> 
> 
> On 9/15/2022 5:40 AM, Fabio M. De Francesco wrote:
> > Pages allocated with GFP_ATOMIC cannot come from Highmem. This is why
> > there is no need to call kmap() on them.
> > 
> > Therefore, don't call kmap() on rx_buffer->page() and instead use a
> > plain page_address() to get the kernel address.
> > 
> > Suggested-by: Ira Weiny <ira.weiny@intel.com>
> > Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
> > Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> > Reviewed-by: Alexander Duyck <alexander.duyck@gmail.com>
> > Tested-by: Gurucharan <gurucharanx.g@intel.com>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > 
> > I send again this patch because it was submitted more than two months ago,
> > Monday 4th July 2022, but for one or more (good?) reasons it has not yet
> > reached Linus' tree. In the meantime I am also forwarding two "Reviewed-by"
> > and one "Tested-by" tags (thanks a lot to Ira, Alexander, Gurucharan).
> > Obviously I have not made any changes to the code.
> 
> Hi Fabio,
> 
> This is accepted into net-next already[1] and will land in the next kernel.

Thanks, sorry just saw this after sending my last.  :-/  :-D

Ira

> 
> Thanks,
> Tony
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=03f51719df032637250af828f9a1ffcc5695982d

  reply	other threads:[~2022-09-15 16:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 12:40 [RESEND PATCH] ixgbe: Don't call kmap() on page allocated with GFP_ATOMIC Fabio M. De Francesco
2022-09-15 16:30 ` Tony Nguyen
2022-09-15 16:58   ` Ira Weiny [this message]
2022-09-15 16:57 ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyNZuTlShCviTKXi@iweiny-desk3 \
    --to=ira.weiny@intel.com \
    --cc=alexander.duyck@gmail.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fmdefrancesco@gmail.com \
    --cc=gurucharanx.g@intel.com \
    --cc=hawk@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jdelvare@suse.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox