From: Colin Foster <colin.foster@in-advantage.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next 2/2] net: mscc: ocelot: check return values of writes during reset
Date: Fri, 16 Sep 2022 16:12:14 -0700 [thread overview]
Message-ID: <YyUCzh0HdEZ3DlQa@euler> (raw)
In-Reply-To: <20220916224009.g4prlpphnji5i4zi@skbuf>
On Fri, Sep 16, 2022 at 10:40:10PM +0000, Vladimir Oltean wrote:
> On Fri, Sep 16, 2022 at 12:13:49PM -0700, Colin Foster wrote:
> > - regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1);
> > - regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1);
> > + err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1);
> > + if (err)
> > + return err;
> >
> > - return 0;
> > + err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1);
> > +
> > + return err;
> > }
>
> A kernel janitor will come and patch this up to:
>
> return regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1);
>
> so it's better to do it yourself.
Good catch. That and removing the IS_ERR_VALUE macro from patch 1 and
I'll resubmit after the weekend.
prev parent reply other threads:[~2022-09-16 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 19:13 [PATCH v1 net-next 0/2] clean up ocelot_reset() routine Colin Foster
2022-09-16 19:13 ` [PATCH v1 net-next 1/2] net: mscc: ocelot: utilize readx_poll_timeout() for chip reset Colin Foster
2022-09-16 22:38 ` Vladimir Oltean
2022-09-16 22:42 ` Colin Foster
2022-09-17 4:05 ` kernel test robot
2022-09-16 19:13 ` [PATCH v1 net-next 2/2] net: mscc: ocelot: check return values of writes during reset Colin Foster
2022-09-16 22:40 ` Vladimir Oltean
2022-09-16 23:12 ` Colin Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyUCzh0HdEZ3DlQa@euler \
--to=colin.foster@in-advantage.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).