netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, linux-phy@lists.infradead.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Russell King <linux@armlinux.org.uk>,
	UNGLinuxDriver@microchip.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH net-next] phy: lan966x: add support for QUSGMII
Date: Tue, 20 Sep 2022 11:48:44 +0530	[thread overview]
Message-ID: <YylbRBPC+0JAvtQU@matsya> (raw)
In-Reply-To: <20220826141722.563352-1-maxime.chevallier@bootlin.com>

On 26-08-22, 16:17, Maxime Chevallier wrote:
> Makes so that the serdes driver also takes QUSGMII in consideration.
> It's configured exactly as QSGMII as far as the serdes driver is
> concerned.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> 
> Dear netdev and Generic PHY maintainers,
> 
> This patch should go through the net-next tree instead of the generic
> PHY tree, as it has a dependency on :
> 
> 5e61fe157a27 "net: phy: Introduce QUSGMII PHY mode"
> 
> This commits only lives in the net-next tree as of today.
> 
> Given the simplicity of this patch, would that be OK for you ?


Sure:

Acked-By: Vinod Koul <vkoul@kernel.org>

> 
> Thanks,
> 
> Maxime
> 
>  drivers/phy/microchip/lan966x_serdes.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/phy/microchip/lan966x_serdes.c b/drivers/phy/microchip/lan966x_serdes.c
> index e86a879b92b5..d1a50fa81130 100644
> --- a/drivers/phy/microchip/lan966x_serdes.c
> +++ b/drivers/phy/microchip/lan966x_serdes.c
> @@ -401,6 +401,9 @@ static int serdes_set_mode(struct phy *phy, enum phy_mode mode, int submode)
>  	    submode == PHY_INTERFACE_MODE_2500BASEX)
>  		submode = PHY_INTERFACE_MODE_SGMII;
>  
> +	if (submode == PHY_INTERFACE_MODE_QUSGMII)
> +		submode = PHY_INTERFACE_MODE_QSGMII;
> +
>  	for (i = 0; i < ARRAY_SIZE(lan966x_serdes_muxes); i++) {
>  		if (macro->idx != lan966x_serdes_muxes[i].idx ||
>  		    mode != lan966x_serdes_muxes[i].mode ||
> -- 
> 2.37.2
> 
> 
> -- 
> linux-phy mailing list
> linux-phy@lists.infradead.org
> https://lists.infradead.org/mailman/listinfo/linux-phy

-- 
~Vinod

      parent reply	other threads:[~2022-09-20  6:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 14:17 [PATCH net-next] phy: lan966x: add support for QUSGMII Maxime Chevallier
2022-08-31 12:00 ` patchwork-bot+netdevbpf
2022-09-20  6:18 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YylbRBPC+0JAvtQU@matsya \
    --to=vkoul@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=horatiu.vultur@microchip.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).