From: Simon Horman <simon.horman@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Diana Wang <na.wang@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>,
Michael Chan <michael.chan@broadcom.com>,
Andy Gospodarek <andy@greyhouse.net>,
Gal Pressman <gal@nvidia.com>, Saeed Mahameed <saeed@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Edward Cree <ecree.xilinx@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: driver uABI review list? (was: Re: [PATCH/RFC net-next 0/3] nfp: support VF multi-queues configuration)
Date: Wed, 21 Sep 2022 15:39:48 +0200 [thread overview]
Message-ID: <YysUJLKZukN8Kirt@corigine.com> (raw)
In-Reply-To: <20220921063448.5b0dd32b@kernel.org>
On Wed, Sep 21, 2022 at 06:34:48AM -0700, Jakub Kicinski wrote:
> On Tue, 20 Sep 2022 16:14:16 +0100 Simon Horman wrote:
> > this short series adds the max_vf_queue generic devlink device parameter,
> > the intention of this is to allow configuration of the number of queues
> > associated with VFs, and facilitates having VFs with different queue
> > counts.
> >
> > The series also adds support for multi-queue VFs to the nfp driver
> > and support for the max_vf_queue feature described above.
>
> I think a similar API was discussed in the past by... Broadcom?
> IIRC they wanted more flexibility, i.e. being able to set the
> guaranteed and max allowed queue count.
>
> Overall this seems like a typical resource division problem so
> we should try to use the devlink resource API or similar. More
> complex policies like guaranteed+max are going to be a pain over
> params.
>
>
> I wanted to ask a more general question, however. I see that you
> haven't CCed even the major (for some def.) vendors' maintainers.
Sorry about that. I should have considered doing so in the first place.
> Would it be helpful for participation if we had a separate mailing
> list for discussing driver uAPI introduction which would hopefully
> be lower traffic? Or perhaps we can require a subject tag ([PATCH
> net-next uapi] ?) so that people can set up email filters?
>
> The cost is obviously yet another process thing to remember, and
> while this is nothing that lore+lei can't already do based on file
> path filters - I doubt y'all care enough to set that up for
> yourselves... :)
Not defending myself here. And not sure if this is helpful.
But the issue for me at the time was not being clear on how to
reach the right audience.
next prev parent reply other threads:[~2022-09-21 13:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 15:14 [PATCH/RFC net-next 0/3] nfp: support VF multi-queues configuration Simon Horman
2022-09-20 15:14 ` [PATCH/RFC net-next 1/3] " Simon Horman
2022-09-20 15:14 ` [PATCH/RFC net-next 2/3] devlink: Add new "max_vf_queue" generic device param Simon Horman
2022-09-20 18:27 ` Edward Cree
2022-09-21 1:47 ` Yinjun Zhang
2022-09-20 15:14 ` [PATCH/RFC net-next 3/3] nfp: devlink: add the devlink parameter "max_vf_queue" support Simon Horman
2022-09-21 13:34 ` driver uABI review list? (was: Re: [PATCH/RFC net-next 0/3] nfp: support VF multi-queues configuration) Jakub Kicinski
2022-09-21 13:39 ` Simon Horman [this message]
2022-09-22 13:37 ` Gal Pressman
2022-09-22 13:49 ` Jakub Kicinski
2022-09-22 16:04 ` Leon Romanovsky
2022-09-22 16:14 ` Jakub Kicinski
2022-09-22 19:08 ` Leon Romanovsky
2022-09-22 19:24 ` Jakub Kicinski
2022-09-22 17:37 ` Andrew Lunn
2022-09-22 19:31 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YysUJLKZukN8Kirt@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=gal@nvidia.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=na.wang@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=peng.zhang@corigine.com \
--cc=saeed@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).