From: Andrew Lunn <andrew@lunn.ch>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
Simon Horman <simon.horman@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Diana Wang <na.wang@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>,
Michael Chan <michael.chan@broadcom.com>,
Andy Gospodarek <andy@greyhouse.net>,
Gal Pressman <gal@nvidia.com>, Saeed Mahameed <saeed@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Edward Cree <ecree.xilinx@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: driver uABI review list? (was: Re: [PATCH/RFC net-next 0/3] nfp: support VF multi-queues configuration)
Date: Thu, 22 Sep 2022 19:37:08 +0200 [thread overview]
Message-ID: <YyydRHGFm/M6rSP5@lunn.ch> (raw)
In-Reply-To: <YyyHg/lvzXHKNPe9@unreal>
On Thu, Sep 22, 2022 at 07:04:19PM +0300, Leon Romanovsky wrote:
> On Wed, Sep 21, 2022 at 06:34:48AM -0700, Jakub Kicinski wrote:
> > On Tue, 20 Sep 2022 16:14:16 +0100 Simon Horman wrote:
> > > this short series adds the max_vf_queue generic devlink device parameter,
> > > the intention of this is to allow configuration of the number of queues
> > > associated with VFs, and facilitates having VFs with different queue
> > > counts.
>
> <...>
>
> > Would it be helpful for participation if we had a separate mailing
> > list for discussing driver uAPI introduction which would hopefully
> > be lower traffic?
>
> Please don't. It will cause to an opposite situation where UAPI
> discussions will be hidden from most people. IMHO, every net vendor
> should be registered to netdev mailing list and read, review and
> participate.
Good in theory, but how often do you really see it happen?
How many vendor developers really do review other vendors drivers
patches. It tends to be vendor neutral reviewers who do reviews across
multiple vendors. I wish there was more cross vendor review, it would
prevent having to repeat the same review comments again and again.
There is probably also a lot of good ideas in some drivers which
should be spread to other drivers. But if you don't look outside your
silo, you are blind to them.
However, i do agree, although netdev is not perfect, i think it is
better than another list which will get even more ignored.
Andrew
next prev parent reply other threads:[~2022-09-22 17:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 15:14 [PATCH/RFC net-next 0/3] nfp: support VF multi-queues configuration Simon Horman
2022-09-20 15:14 ` [PATCH/RFC net-next 1/3] " Simon Horman
2022-09-20 15:14 ` [PATCH/RFC net-next 2/3] devlink: Add new "max_vf_queue" generic device param Simon Horman
2022-09-20 18:27 ` Edward Cree
2022-09-21 1:47 ` Yinjun Zhang
2022-09-20 15:14 ` [PATCH/RFC net-next 3/3] nfp: devlink: add the devlink parameter "max_vf_queue" support Simon Horman
2022-09-21 13:34 ` driver uABI review list? (was: Re: [PATCH/RFC net-next 0/3] nfp: support VF multi-queues configuration) Jakub Kicinski
2022-09-21 13:39 ` Simon Horman
2022-09-22 13:37 ` Gal Pressman
2022-09-22 13:49 ` Jakub Kicinski
2022-09-22 16:04 ` Leon Romanovsky
2022-09-22 16:14 ` Jakub Kicinski
2022-09-22 19:08 ` Leon Romanovsky
2022-09-22 19:24 ` Jakub Kicinski
2022-09-22 17:37 ` Andrew Lunn [this message]
2022-09-22 19:31 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyydRHGFm/M6rSP5@lunn.ch \
--to=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=gal@nvidia.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=na.wang@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=peng.zhang@corigine.com \
--cc=saeed@kernel.org \
--cc=simon.horman@corigine.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).