From: Simon Horman <simon.horman@corigine.com>
To: Juhee Kang <claudiajkang@gmail.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
skhan@linuxfoundation.org, oss-drivers@netronome.com
Subject: Re: [PATCH net-next 3/3] nfp: abm: use netdev_unregistering instead of open code
Date: Mon, 26 Sep 2022 09:48:15 +0200 [thread overview]
Message-ID: <YzFZP7W7cSXDsnuu@corigine.com> (raw)
In-Reply-To: <20220923160937.1912-3-claudiajkang@gmail.com>
+oss-drivers@netronome.com
On Sat, Sep 24, 2022 at 01:09:37AM +0900, Juhee Kang wrote:
> [You don't often get email from claudiajkang@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> The open code is defined as a helper function(netdev_unregistering)
> on netdev.h, which the open code is dev->reg_state == NETREG_UNREGISTERING.
> Thus, netdev_unregistering() replaces the open code. This patch doesn't
> change logic.
>
> Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2022-09-26 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 16:09 [PATCH net-next 1/3] net: use netdev_unregistering instead of open code Juhee Kang
2022-09-23 16:09 ` [PATCH net-next 2/3] ethtool: " Juhee Kang
2022-09-26 7:45 ` Simon Horman
2022-09-23 16:09 ` [PATCH net-next 3/3] nfp: abm: " Juhee Kang
2022-09-26 7:48 ` Simon Horman [this message]
2022-09-26 7:44 ` [PATCH net-next 1/3] net: " Simon Horman
2022-09-26 8:05 ` Juhee Kang
2022-09-26 8:19 ` Simon Horman
2022-09-26 8:25 ` Juhee Kang
2022-09-26 8:27 ` Simon Horman
2022-09-26 8:29 ` Juhee Kang
2022-09-26 17:04 ` Jakub Kicinski
2022-09-26 17:45 ` Jakub Kicinski
2022-09-28 14:57 ` Juhee Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzFZP7W7cSXDsnuu@corigine.com \
--to=simon.horman@corigine.com \
--cc=claudiajkang@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).