From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02983C07E9D for ; Mon, 26 Sep 2022 09:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbiIZJJU (ORCPT ); Mon, 26 Sep 2022 05:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233527AbiIZJJT (ORCPT ); Mon, 26 Sep 2022 05:09:19 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C154201A5 for ; Mon, 26 Sep 2022 02:09:15 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id q35-20020a17090a752600b002038d8a68fbso11793091pjk.0 for ; Mon, 26 Sep 2022 02:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=zIwJkcfZiCJVcK2gsBhTYdXWB93nNMAsAQ0HD2M23SQ=; b=YFNize90a964bkhN4otkl/tclWwGNbzaGVgp6NAPKLOBXqxjFVnT6u8NWvbA5OuRoT QvZcNzJ7ISfwJ0f3dWSMX6vzasJv8vyysrhjn2xyVxwuEwAIlJ6UCaQTjowI1r11g8Wb CPSNHy8jbmPxMaGi88T2ZKSNqzWiBKlOXK3ksymo6Tn6jK3op5napXg7ELL8ARmHtnfb EPfBRwHMTfZv5peH6TxBbHuMUnvxueDOKlR/MZYy1CLINVw1zqdezgE8QfNUNKULtutv FWVW6nlny4tkk1CVFZ0afFmkVS1nrIKM1y9tYEPcmr+Ju4qfCjPBoUTRJgq2ANwqd6+w e1vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=zIwJkcfZiCJVcK2gsBhTYdXWB93nNMAsAQ0HD2M23SQ=; b=zYuLu8lrRQ3eqqPquwU9xfWZP4Ij3ZsxgsGljHbg+JIYEbNTVDozAu5a/8X/d1zfN+ +1e18aTQK2YLV5JhzTJYVtTMGMkxFeCIivcwvUhONaHNx5IV0hU76WmBjQL0ACYWb88r NJXZeXdYgWjXzq6Ii0fPKQfwdvoIKd7jot307W8k9xX2qiPWT0NrewhqVY2/7cb7V+Er ZdgJIIf9p6ugMHsxS60mzSVqT6tLkvEIE3YCieeH3K/rOaH965D4RjX83jx30nizn+VV J34sm+SB41Hv707y6sp1ojlhT+CgL9bdVZV4DAACl/B3m29iaj7hODwAcitS5UVSWXBr o7Ug== X-Gm-Message-State: ACrzQf0yotoLASQ2zHA8PsKZx7Y/eEHFDmLV3YyV0M1pSdkjNoWYuIKU 9dIC9Sjn7uQdBqN6mt2cm1s= X-Google-Smtp-Source: AMsMyM6Urlo72pi2O0vl4DVsMQefCMrBHjP7K2lUv6M8OpOw6yZJv3CxPEzuj8KxtiTAen+jX7zMJA== X-Received: by 2002:a17:902:f70e:b0:178:9a17:8e42 with SMTP id h14-20020a170902f70e00b001789a178e42mr21458053plo.14.1664183354613; Mon, 26 Sep 2022 02:09:14 -0700 (PDT) Received: from Laptop-X1 ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id g11-20020a63200b000000b00439f027789asm10282807pgg.59.2022.09.26.02.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 02:09:14 -0700 (PDT) Date: Mon, 26 Sep 2022 17:09:09 +0800 From: Hangbin Liu To: Nicolas Dichtel Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ido Schimmel , Petr Machata , Florent Fourcot , Nikolay Aleksandrov , Guillaume Nault Subject: Re: [PATCHv2 net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set, del}link Message-ID: References: <20220926071246.38805-1-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Sep 26, 2022 at 10:37:46AM +0200, Nicolas Dichtel wrote: > > + rtnl_notify(skb, dev_net(dev), pid, RTM_NEWLINK, nlh, GFP_KERNEL); > The fourth argument is the group, not the command. It should be RTNLGRP_LINK > here. But it would be better to pass 0 to avoid multicasting a new / duplicate > notification. Calling functions already multicast one. Thanks for the correcting. I will post a new update. Hangbin