From: Jiri Pirko <jiri@resnulli.us>
To: Phil Sutter <phil@nwl.cc>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [RESEND net-next PATCH] net: rtnetlink: Enslave device before bringing it up
Date: Mon, 26 Sep 2022 13:13:58 +0200 [thread overview]
Message-ID: <YzGJdsH1csfPc8gM@nanopsycho> (raw)
In-Reply-To: <20220914150623.24152-1-phil@nwl.cc>
Wed, Sep 14, 2022 at 05:06:23PM CEST, phil@nwl.cc wrote:
>Unlike with bridges, one can't add an interface to a bond and set it up
>at the same time:
>
>| # ip link set dummy0 down
>| # ip link set dummy0 master bond0 up
>| Error: Device can not be enslaved while up.
>
>Of all drivers with ndo_add_slave callback, bond and team decline if
>IFF_UP flag is set, vrf cycles the interface (i.e., sets it down and
>immediately up again) and the others just don't care.
>
>Support the common notion of setting the interface up after enslaving it
>by sorting the operations accordingly.
>
>Signed-off-by: Phil Sutter <phil@nwl.cc>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
prev parent reply other threads:[~2022-09-26 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 15:06 [RESEND net-next PATCH] net: rtnetlink: Enslave device before bringing it up Phil Sutter
2022-09-18 15:48 ` David Ahern
2022-09-20 15:50 ` patchwork-bot+netdevbpf
2022-09-26 11:13 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzGJdsH1csfPc8gM@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox