From: Andrew Lunn <andrew@lunn.ch>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] net: ethernet: renesas: Add Ethernet Switch driver
Date: Wed, 28 Sep 2022 14:01:05 +0200 [thread overview]
Message-ID: <YzQ3gdO/a+jygIDa@lunn.ch> (raw)
In-Reply-To: <TYBPR01MB53419D2076953EB3480BC301D8549@TYBPR01MB5341.jpnprd01.prod.outlook.com>
> > How do you direct a frame from the
> > CPU out a specific user port? Via the DMA ring you place it into, or
> > do you need a tag on the frame to indicate its egress port?
>
> Via the DMA ring.
Are there bits in the ring descriptor which indicate the user port?
Can you set these bits to some other value which causes the switch to
use its MAC table to determine the egress interface?
> > > The PHY is 88E2110 on my environment, so Linux has a driver in
> > > drivers/net/phy/marvell10g.c. However, I guess this is related to
> > > configuration of the PHY chip on the board, it needs to change
> > > the host 7interface mode, but the driver doesn't support it for now.
> >
> > Please give us more details. The marvell10g driver will change its
> > host side depending on the result of the line side negotiation. It
> > changes the value of phydev->interface to indicate what is it doing on
> > its host side, and you have some control over what modes it will use
> > on the host side. You can probably define its initial host side mode
> > via phy-mode in DT.
>
> I'm sorry, my explanation was completely wrong.
> My environment needs to change default MAC speed from 2.5G/5G to 1000M.
> The register of 88E2110 is 31.F000.7:6. And sets the register to "10" (1000 Mbps).
> (Default value of the register is "11" (Speed controlled by other register).)
Is this the host side speed? The speed of the SERDES between the
switch and the PHY? Normally, the PHY determines this from the line
side. If the line side is using 2.5G, it will set the host side to
2500BaseX. If the line side is 1G, the host side is likely to be
SGMII.
You have already removed speeds you don't support. So the PHY will not
negotiate 2.5G or 5G. It is limited to 1G. So it should always have
the host side as SGMII. This should be enough to make it work.
Andrew
next prev parent reply other threads:[~2022-09-28 12:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 5:28 [PATCH v3 0/3] net: ethernet: renesas: Add Ethernet Switch driver Yoshihiro Shimoda
2022-09-22 5:28 ` [PATCH v3 1/3] dt-bindings: net: renesas: Document Renesas Ethernet Switch Yoshihiro Shimoda
2022-09-22 7:39 ` Krzysztof Kozlowski
2022-09-22 5:28 ` [PATCH v3 2/3] net: ethernet: renesas: Add Ethernet Switch driver Yoshihiro Shimoda
2022-09-23 2:43 ` Jakub Kicinski
2022-09-26 6:30 ` Yoshihiro Shimoda
2022-09-23 13:11 ` Andrew Lunn
2022-09-26 8:12 ` Yoshihiro Shimoda
2022-09-26 19:17 ` Andrew Lunn
2022-09-27 5:59 ` Yoshihiro Shimoda
2022-09-27 12:54 ` Andrew Lunn
2022-09-28 5:53 ` Yoshihiro Shimoda
2022-09-28 12:01 ` Andrew Lunn [this message]
2022-09-29 12:22 ` Yoshihiro Shimoda
2022-09-29 15:00 ` Andrew Lunn
2022-09-30 13:45 ` Yoshihiro Shimoda
2022-09-22 5:28 ` [PATCH v3 3/3] net: ethernet: renesas: rswitch: Add R-Car Gen4 gPTP support Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzQ3gdO/a+jygIDa@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).