From: Alexey Dobriyan <adobriyan@gmail.com>
To: viro@zeniv.linux.org.uk
Cc: ebiederm@xmission.com, torvalds@linux-foundation.org,
David.Laight@aculab.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, serge@hallyn.com
Subject: Re: [CFT][PATCH] proc: Update /proc/net to point at the accessing threads network namespace
Date: Fri, 30 Sep 2022 17:01:03 +0300 [thread overview]
Message-ID: <Yzb2nyYK94gcOKOR@localhost.localdomain> (raw)
Al wrote:
> Just to troll adobriyan a bit:
>
> static const char *dynamic_get_link(struct delayed_call *done,
> bool is_rcu,
> const char *fmt, ...)
> {
> va_list args;
> char *body;
>
> va_start(args, fmt);
> body = kvasprintf(is_rcu ? GFP_ATOMIC : GFP_KERNEL, fmt, args);
> va_end(args);
Ouch... Double pass over data. Who wrote this?
>
> if (unlikely(!body))
> return is_rcu ? ERR_PTR(-ECHILD) : ERR_PTR(-ENOMEM);
> set_delayed_call(done, kfree_link, body);
> return body;
> }
next reply other threads:[~2022-09-30 14:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 14:01 Alexey Dobriyan [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-29 15:22 [PATCH 3/4] proc: Point /proc/net at /proc/thread-self/net instead of /proc/self/net David Laight
2022-09-29 18:21 ` Linus Torvalds
2022-09-29 18:50 ` Al Viro
2022-09-29 19:00 ` Al Viro
2022-09-29 19:05 ` Linus Torvalds
2022-09-29 19:34 ` Al Viro
2022-09-29 21:15 ` Al Viro
2022-09-29 21:29 ` Linus Torvalds
2022-09-29 22:14 ` Eric W. Biederman
2022-09-29 22:48 ` [CFT][PATCH] proc: Update /proc/net to point at the accessing threads network namespace Eric W. Biederman
2022-09-29 23:38 ` Al Viro
2022-09-30 3:19 ` kernel test robot
2022-09-30 6:07 ` kernel test robot
2022-09-30 9:30 ` David Laight
2022-09-30 16:17 ` Eric W. Biederman
2022-09-30 21:28 ` David Laight
2022-10-01 23:11 ` Al Viro
2022-10-03 9:36 ` David Laight
2022-10-03 14:03 ` Al Viro
2022-10-03 17:07 ` Eric W. Biederman
2022-10-03 18:49 ` Al Viro
2022-10-04 8:53 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzb2nyYK94gcOKOR@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=David.Laight@aculab.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).