Re: [PATCHv5 net-next 1/4] rtnetlink: add new helper rtnl_configure_link_notify()

Hangbin Liu
2022-10-04T08:22:18Z

On Fri, Sep 30, 2022 at 11:40:21PM +0200, Nicolas Dichtel wrote:
> Le 30/09/2022 à 18:01, Guillaume Nault a écrit :
> > On Fri, Sep 30, 2022 at 04:22:19PM +0200, Nicolas Dichtel wrote:
> >> Le 30/09/2022 à 11:45, Hangbin Liu a écrit :
> >>> -int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm)
> >>> +static int rtnl_configure_link_notify(struct net_device *dev, const struct ifinfomsg *ifm,
> >>> + struct nlmsghdr *nlh, u32 pid)
> >> But not here. Following patches also use this order instead of the previous one.
> >> For consistency, it could be good to keep the same order everywhere.
> >
> > Yes, since a v6 will be necessary anyway, let's be consistent about the
> > order of parameters. That helps reading the code.
> >
> > While there, I'd prefer to use 'portid' instead of 'pid'. I know
> > rtnetlink.c uses both, but 'portid' is more explicit and is what
> > af_netlink.c generally uses.
> >
> +1
>
> pid is historical but too confusing.

Thanks for all the comments. I will post the new patch when net-next
re-open.

Hangbin