From: Michal Kubiak <michal.kubiak@intel.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] net: airoha: Add airoha_ppe_foe_flow_remove_entry_locked()
Date: Tue, 8 Apr 2025 22:12:44 +0200 [thread overview]
Message-ID: <Z/WDPBMIPSCkbg9e@localhost.localdomain> (raw)
In-Reply-To: <20250407-airoha-flowtable-l2b-v1-2-18777778e568@kernel.org>
On Mon, Apr 07, 2025 at 04:18:31PM +0200, Lorenzo Bianconi wrote:
> Introduce airoha_ppe_foe_flow_remove_entry_locked utility routine
> in order to run airoha_ppe_foe_flow_remove_entry holding ppe_lock.
> This is a preliminary patch to L2 offloading support to airoha_eth
> driver.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Could you please explain the reason of introducing the *_remove_entry_locked
function if "airoha_ppe_foe_flow_remove_entry()" is still never called out of
"airoha_ppe_foe_flow_remove_entry_locked()" context (at least in this
series)?
I would expect that it can be useful if you have an use case when you want
to call "airoha_ppe_foe_flow_remove_entry()" from another function that
has already taken the lock, but I haven't found such a context.
Thanks,
Michal
next prev parent reply other threads:[~2025-04-08 20:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 14:18 [PATCH net-next 0/3] Add L2 hw acceleration for airoha_eth driver Lorenzo Bianconi
2025-04-07 14:18 ` [PATCH net-next 1/3] net: airoha: Add l2_flows rhashtable Lorenzo Bianconi
2025-04-08 15:36 ` Michal Kubiak
2025-04-08 16:49 ` Lorenzo Bianconi
2025-04-08 18:41 ` Michal Kubiak
2025-04-08 18:57 ` Jakub Kicinski
2025-04-08 22:54 ` Lorenzo Bianconi
2025-04-07 14:18 ` [PATCH net-next 2/3] net: airoha: Add airoha_ppe_foe_flow_remove_entry_locked() Lorenzo Bianconi
2025-04-08 20:12 ` Michal Kubiak [this message]
2025-04-08 23:23 ` Lorenzo Bianconi
2025-04-07 14:18 ` [PATCH net-next 3/3] net: airoha: Add L2 hw acceleration support Lorenzo Bianconi
2025-04-08 19:56 ` Michal Kubiak
2025-04-08 23:19 ` Lorenzo Bianconi
2025-04-08 18:52 ` [PATCH net-next 0/3] Add L2 hw acceleration for airoha_eth driver Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/WDPBMIPSCkbg9e@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).