Netdev List
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org, jakub@cloudflare.com,
	john.fastabend@gmail.com, zhoufeng.zf@bytedance.com
Subject: Re: [Patch bpf-next v2 0/4] tcp_bpf: improve ingress redirection performance with message corking
Date: Wed, 9 Apr 2025 10:54:36 -0700	[thread overview]
Message-ID: <Z/a0XH5lqh7raKd6@pop-os.localdomain> (raw)
In-Reply-To: <20250306220205.53753-1-xiyou.wangcong@gmail.com>

Hi John,

On Thu, Mar 06, 2025 at 02:02:01PM -0800, Cong Wang wrote:
> This patchset improves skmsg ingress redirection performance by a)
> sophisticated batching with kworker; b) skmsg allocation caching with
> kmem cache.
> 
> As a result, our patches significantly outperforms the vanilla kernel
> in terms of throughput for almost all packet sizes. The percentage
> improvement in throughput ranges from 3.13% to 160.92%, with smaller
> packets showing the highest improvements.
> 
> For latency, it induces slightly higher latency across most packet sizes
> compared to the vanilla, which is also expected since this is a natural
> side effect of batching.
> 

Per our in-person conversation at LSF/MM/BPF, you are okay with this
patchset. If so, may we get your ACK here? If not, please let us know
what changes you prefer to make for V3?

Thanks!

      parent reply	other threads:[~2025-04-09 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 22:02 [Patch bpf-next v2 0/4] tcp_bpf: improve ingress redirection performance with message corking Cong Wang
2025-03-06 22:02 ` [Patch bpf-next v2 1/4] skmsg: rename sk_msg_alloc() to sk_msg_expand() Cong Wang
2025-03-06 22:02 ` [Patch bpf-next v2 2/4] skmsg: implement slab allocator cache for sk_msg Cong Wang
2025-03-06 22:02 ` [Patch bpf-next v2 3/4] skmsg: save some space in struct sk_psock Cong Wang
2025-03-06 22:02 ` [Patch bpf-next v2 4/4] tcp_bpf: improve ingress redirection performance with message corking Cong Wang
2025-03-11 20:54   ` John Fastabend
2025-03-12 18:20     ` Zijian Zhang
2025-04-09 17:54 ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z/a0XH5lqh7raKd6@pop-os.localdomain \
    --to=xiyou.wangcong@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=jakub@cloudflare.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=zhoufeng.zf@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox