[PATCH v2] net: wwan: Add error handling for ipc_mux_dl_acb_send_cmds().

[PATCH v2] net: wwan: Add error handling for ipc_mux_dl_acb_send_cmds().

[Wentao Liang]

The ipc_mux_dl_acbcmd_decode() calls the ipc_mux_dl_acb_send_cmds(),
but does not report the error if ipc_mux_dl_acb_send_cmds() fails.
This makes it difficult to detect command sending failures. A proper
implementation can be found in ipc_mux_dl_cmd_decode().

Add error reporting to the call, logging an error message using dev_err()
if the command sending fails.

Fixes: 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support")
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
index bff46f7ca59f..478c9c8b638b 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
@@ -509,8 +509,11 @@ static void ipc_mux_dl_acbcmd_decode(struct iosm_mux *ipc_mux,
 			return;
 			}
 		trans_id = le32_to_cpu(cmdh->transaction_id);
-		ipc_mux_dl_acb_send_cmds(ipc_mux, cmd, cmdh->if_id,
-					 trans_id, cmd_p, size, false, true);
+		if (ipc_mux_dl_acb_send_cmds(ipc_mux, cmd, cmdh->if_id,
+					     trans_id, cmd_p, size, false, true))
+			dev_err(ipc_mux->dev,
+				"if_id %d: cmd send failed",
+				cmdh->if_id);
 	}
 }
 
-- 
2.42.0.windows.2

Re: [PATCH v2] net: wwan: Add error handling for ipc_mux_dl_acb_send_cmds().

[Michal Swiatkowski]

On Thu, Apr 03, 2025 at 04:48:00PM +0800, Wentao Liang wrote:
> The ipc_mux_dl_acbcmd_decode() calls the ipc_mux_dl_acb_send_cmds(),
> but does not report the error if ipc_mux_dl_acb_send_cmds() fails.
> This makes it difficult to detect command sending failures. A proper
> implementation can be found in ipc_mux_dl_cmd_decode().
> 
> Add error reporting to the call, logging an error message using dev_err()
> if the command sending fails.
> 
> Fixes: 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support")
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
> index bff46f7ca59f..478c9c8b638b 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
> +++ b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
> @@ -509,8 +509,11 @@ static void ipc_mux_dl_acbcmd_decode(struct iosm_mux *ipc_mux,
>  			return;
>  			}
>  		trans_id = le32_to_cpu(cmdh->transaction_id);
> -		ipc_mux_dl_acb_send_cmds(ipc_mux, cmd, cmdh->if_id,
> -					 trans_id, cmd_p, size, false, true);
> +		if (ipc_mux_dl_acb_send_cmds(ipc_mux, cmd, cmdh->if_id,
> +					     trans_id, cmd_p, size, false, true))
> +			dev_err(ipc_mux->dev,
> +				"if_id %d: cmd send failed",
> +				cmdh->if_id);

Shouldn't it go to the net-next? It isn't fixing anything, just adding
error message.

>  	}
>  }
>  
> -- 
> 2.42.0.windows.2

Re: [PATCH v2] net: wwan: Add error handling for ipc_mux_dl_acb_send_cmds().

[Sergey Ryazanov]

On 04.04.2025 10:14, Michal Swiatkowski wrote:
> On Thu, Apr 03, 2025 at 04:48:00PM +0800, Wentao Liang wrote:
>> The ipc_mux_dl_acbcmd_decode() calls the ipc_mux_dl_acb_send_cmds(),
>> but does not report the error if ipc_mux_dl_acb_send_cmds() fails.
>> This makes it difficult to detect command sending failures. A proper
>> implementation can be found in ipc_mux_dl_cmd_decode().
>>
>> Add error reporting to the call, logging an error message using dev_err()
>> if the command sending fails.
>>
>> Fixes: 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support")
>> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
>> ---
>>   drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
>> index bff46f7ca59f..478c9c8b638b 100644
>> --- a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
>> +++ b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
>> @@ -509,8 +509,11 @@ static void ipc_mux_dl_acbcmd_decode(struct iosm_mux *ipc_mux,
>>   			return;
>>   			}
>>   		trans_id = le32_to_cpu(cmdh->transaction_id);
>> -		ipc_mux_dl_acb_send_cmds(ipc_mux, cmd, cmdh->if_id,
>> -					 trans_id, cmd_p, size, false, true);
>> +		if (ipc_mux_dl_acb_send_cmds(ipc_mux, cmd, cmdh->if_id,
>> +					     trans_id, cmd_p, size, false, true))
>> +			dev_err(ipc_mux->dev,
>> +				"if_id %d: cmd send failed",
>> +				cmdh->if_id);
> 
> Shouldn't it go to the net-next? It isn't fixing anything, just adding
> error message.

Michal, you are right. Patch does not fix a user's problem.

Wentao, could you resend the patch without 'Fixes' tag and targeting 
'net-next' tree (the subject should be 'PATH net-next v?').

> 
>>   	}
>>   }
>>   
>> -- 
>> 2.42.0.windows.2