Re: [PATCH net] sfc: fix NULL dereferences in ef100_process_design_param()

[Michal Swiatkowski <michal.swiatkowski@linux.intel.com>]

On Wed, Apr 02, 2025 at 09:15:02AM +0100, Edward Cree wrote:
> On 02/04/2025 06:17, Michal Swiatkowski wrote:
> > On Tue, Apr 01, 2025 at 11:54:39PM +0100, edward.cree@amd.com wrote:
> >> -	netif_set_tso_max_segs(net_dev,
> >> -			       ESE_EF100_DP_GZ_TSO_MAX_HDR_NUM_SEGS_DEFAULT);
> >> +	nic_data = efx->nic_data;
> >> +	netif_set_tso_max_size(efx->net_dev, nic_data->tso_max_payload_len);
> >> +	netif_set_tso_max_segs(efx->net_dev, nic_data->tso_max_payload_num_segs);
> > 
> > Is it fine to drop default value for max segs? Previously if somehow
> > this value wasn't read from HW it was set to default, now it will be 0.
> > 
> > At the beggining of ef100_probe_main() default values for nic_data are
> > set. Maybe it is worth to set also this default for max segs?
> 
> As I read it, ef100_probe_main() does set a default for this nic_data
>  field along with the others, and sets it to exactly this same value.
> 

Sorry, right, I somehow missed it.

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

> confused,
> -ed