From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Johan Korsnes <johan.korsnes@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] net: au1000_eth: Mark au1000_ReleaseDB() static
Date: Mon, 24 Mar 2025 07:01:26 +0100 [thread overview]
Message-ID: <Z+D1NpUDCsIZLAEP@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250323190450.111241-1-johan.korsnes@gmail.com>
On Sun, Mar 23, 2025 at 08:04:50PM +0100, Johan Korsnes wrote:
> This fixes the following build warning:
> ```
> drivers/net/ethernet/amd/au1000_eth.c:574:6: warning: no previous prototype for 'au1000_ReleaseDB' [-Wmissing-prototypes]
> 574 | void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB)
> | ^~~~~~~~~~~~~~~~
> ```
>
> Signed-off-by: Johan Korsnes <johan.korsnes@gmail.com>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> ---
> drivers/net/ethernet/amd/au1000_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c
> index 0671a066913b..9d35ac348ebe 100644
> --- a/drivers/net/ethernet/amd/au1000_eth.c
> +++ b/drivers/net/ethernet/amd/au1000_eth.c
> @@ -571,7 +571,7 @@ static struct db_dest *au1000_GetFreeDB(struct au1000_private *aup)
> return pDB;
> }
>
> -void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB)
> +static void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB)
> {
> struct db_dest *pDBfree = aup->pDBfree;
> if (pDBfree)
Thanks for fixing it
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
You didn't specify the tree (net vs net-next in [PATCH ...]). If you
want it to go to net you will need fixes tag, if to net-next it is fine.
> --
> 2.49.0
next prev parent reply other threads:[~2025-03-24 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 19:04 [PATCH] net: au1000_eth: Mark au1000_ReleaseDB() static Johan Korsnes
2025-03-24 6:01 ` Michal Swiatkowski [this message]
2025-03-24 8:21 ` Johan Korsnes
2025-03-25 9:45 ` Jakub Kicinski
2025-03-25 15:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z+D1NpUDCsIZLAEP@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johan.korsnes@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).