netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	netdev@vger.kernel.org, hkallweit1@gmail.com,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [net PATCH 1/2] net: phy: Cleanup handling of recent changes to phy_lookup_setting
Date: Fri, 4 Apr 2025 08:16:52 +0100	[thread overview]
Message-ID: <Z--HZCOqBvyQcmd9@shell.armlinux.org.uk> (raw)
In-Reply-To: <8acfd058-5baf-4a34-9868-a698f877ea08@lunn.ch>

On Fri, Apr 04, 2025 at 03:46:01AM +0200, Andrew Lunn wrote:
> On Fri, Apr 04, 2025 at 12:26:15AM +0100, Russell King (Oracle) wrote:
> > On Thu, Apr 03, 2025 at 02:53:22PM -0700, Alexander Duyck wrote:
> > > How is it not a fixed link? If anything it was going to be more fixed
> > > than what you described above.
> > 
> > I had to laugh at this. Really. I don't think you quite understand the
> > case that Andrew was referring to.
> > 
> > While he said MAC to MAC, he's not just referring to two MACs that
> > software can program to operate at any speed, thus achieving a link
> > without autoneg. He is also talking about cases where one end is
> > fixed e.g. by pinstrapping to a specific configuration including
> > speed, and using anything different on the host MAC side results in
> > no link.
> 
> Yep, this is pretty typical of SOHO switches, you use strapping to set
> the port, and it never changes, at least not without a soldering iron
> to take off/add resistors. There are also some SOHO switches which
> have a dedicated 'cpu port' and there is no configuration options at
> all. The CPU MAC must conform to what the switch MAC is doing.

From the sounds of it, Alexander seems to want to use fixed-link
differently - take parameters from firmware, build swnodes, and
set the MAC up for a fixed link with variable "media" type. So
it's not really fixed, but "do what the firmware says". I can't see
that being much different to other platforms which have firmware
that gives us the link parameters.

Presumably in Alexander's case, the firmware also gives link up/down
notifications as well, so it seems to me that this isn't really a
fixed link at all.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2025-04-04  7:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 21:29 [net PATCH 0/2] Fixes for net/phy/phylink.c Alexander Duyck
2025-04-01 21:30 ` [net PATCH 1/2] net: phy: Cleanup handling of recent changes to phy_lookup_setting Alexander Duyck
2025-04-02  7:00   ` Maxime Chevallier
2025-04-02 14:21     ` Alexander H Duyck
2025-04-02 17:17       ` Jakub Kicinski
2025-04-02 17:30         ` Russell King (Oracle)
2025-04-02 22:37           ` Alexander Duyck
2025-04-03 14:55   ` Russell King (Oracle)
2025-04-03 15:29     ` Maxime Chevallier
2025-04-03 16:34       ` Andrew Lunn
2025-04-03 21:53         ` Alexander Duyck
2025-04-03 23:19           ` Russell King (Oracle)
2025-04-04 15:56             ` Alexander Duyck
2025-04-04 16:33               ` Andrew Lunn
2025-04-04 22:46                 ` Alexander Duyck
2025-04-05  9:43                   ` Russell King (Oracle)
2025-04-05 14:51                   ` Andrew Lunn
2025-04-05 20:41                     ` Alexander Duyck
2025-04-05 20:53                       ` Andrew Lunn
2025-04-05  9:10               ` Russell King (Oracle)
2025-04-05 15:43                 ` Andrew Lunn
2025-04-05 15:52                 ` Andrew Lunn
2025-04-05 16:19                   ` Alexander Duyck
2025-04-05 20:23                 ` Alexander Duyck
2025-04-03 23:26           ` Russell King (Oracle)
2025-04-04  1:46             ` Andrew Lunn
2025-04-04  7:16               ` Russell King (Oracle) [this message]
2025-04-04 16:18                 ` Alexander Duyck
2025-04-07 17:01                   ` Jakub Kicinski
2025-04-07 18:20                     ` Alexander Duyck
2025-04-07 19:34                       ` Andrew Lunn
2025-04-07 23:01                         ` Alexander Duyck
2025-04-01 21:30 ` [net PATCH 2/2] net: phylink: Set advertising based on phy_lookup_setting in ksettings_set Alexander Duyck
2025-04-02 18:02   ` Russell King (Oracle)
2025-04-02 22:34     ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z--HZCOqBvyQcmd9@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=alexander.duyck@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).