From: Stanislav Fomichev <stfomichev@gmail.com>
To: Ivan Abramov <i.abramov@mt-integration.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
syzbot+1df6ffa7a6274ae264db@syzkaller.appspotmail.com,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Ahmed Zaki <ahmed.zaki@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH net v2] net: Avoid calling WARN_ON() on -ENOMEM in netif_change_net_namespace()
Date: Thu, 3 Apr 2025 11:05:31 -0700 [thread overview]
Message-ID: <Z-7N60DKIDLS2GXe@mini-arch> (raw)
In-Reply-To: <20250403113519.992462-1-i.abramov@mt-integration.ru>
On 04/03, Ivan Abramov wrote:
> It's pointless to call WARN_ON() in case of an allocation failure in
> device_rename(), since it only leads to useless splats caused by deliberate
> fault injections, so avoid it.
What if this happens in a non-fault injection environment? Suppose
the user shows up and says that he's having an issue with device
changing its name after netns change. There will be no way to diagnose
it, right?
next prev parent reply other threads:[~2025-04-03 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 11:35 [PATCH net v2] net: Avoid calling WARN_ON() on -ENOMEM in netif_change_net_namespace() Ivan Abramov
2025-04-03 18:05 ` Stanislav Fomichev [this message]
2025-04-04 7:29 ` Ivan Abramov
2025-04-04 8:53 ` Eric Dumazet
2025-04-07 10:19 ` Ivan Abramov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-7N60DKIDLS2GXe@mini-arch \
--to=stfomichev@gmail.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.abramov@mt-integration.ru \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=syzbot+1df6ffa7a6274ae264db@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).