From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Masahisa Kojima <kojima.masahisa@socionext.com>,
Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Felix Fietkau <nbd@nbd.name>, Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Roger Quadros <rogerq@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-hyperv@vger.kernel.org,
linux-omap@vger.kernel.org,
Michal Kubiak <michal.kubiak@intel.com>
Subject: Re: [PATCH net-next v2 4/7] net: octeontx2: Add metadata support for xdp mode
Date: Tue, 25 Mar 2025 14:28:41 +0100 [thread overview]
Message-ID: <Z-Kvia3EhrtAjKOG@lore-rh-laptop> (raw)
In-Reply-To: <20250325044126.1c0f9b83@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
> On Tue, 18 Mar 2025 12:46:08 +0100 Lorenzo Bianconi wrote:
> > @@ -1514,13 +1518,14 @@ static bool otx2_xdp_rcv_pkt_handler(struct otx2_nic *pfvf,
> >
> > hard_start = (unsigned char *)phys_to_virt(pa);
> > xdp_prepare_buff(&xdp, hard_start, OTX2_HEAD_ROOM,
> > - cqe->sg.seg_size, false);
> > + cqe->sg.seg_size, true);
> >
> > act = bpf_prog_run_xdp(prog, &xdp);
> >
> > handle_xdp_verdict:
> > switch (act) {
> > case XDP_PASS:
> > + *metasize = xdp.data - xdp.data_meta;
> > break;
> > case XDP_TX:
> > qidx += pfvf->hw.tx_queues;
>
> This one handles ABORT and invalid return codes as PASS not DROP.
> That should probably be fixed separately?
Yes, right. I will post a fix for it.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-03-25 13:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 11:46 [PATCH net-next v2 0/7] net: xdp: Add missing metadata support for some xdp drvs Lorenzo Bianconi
2025-03-18 11:46 ` [PATCH net-next v2 1/7] net: mvneta: Add metadata support for xdp mode Lorenzo Bianconi
2025-03-18 11:46 ` [PATCH net-next v2 2/7] net: mvpp2: " Lorenzo Bianconi
2025-03-18 11:46 ` [PATCH net-next v2 3/7] net: netsec: " Lorenzo Bianconi
2025-03-18 11:46 ` [PATCH net-next v2 4/7] net: octeontx2: " Lorenzo Bianconi
2025-03-25 11:41 ` Jakub Kicinski
2025-03-25 13:28 ` Lorenzo Bianconi [this message]
2025-03-18 11:46 ` [PATCH net-next v2 5/7] net: ethernet: mediatek: " Lorenzo Bianconi
2025-03-18 11:46 ` [PATCH net-next v2 6/7] net: mana: " Lorenzo Bianconi
2025-03-18 11:46 ` [PATCH net-next v2 7/7] net: ti: cpsw: " Lorenzo Bianconi
2025-03-25 11:50 ` [PATCH net-next v2 0/7] net: xdp: Add missing metadata support for some xdp drvs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-Kvia3EhrtAjKOG@lore-rh-laptop \
--to=lorenzo@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ast@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=haiyangz@microsoft.com \
--cc=hawk@kernel.org \
--cc=hkelam@marvell.com \
--cc=ilias.apalodimas@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kojima.masahisa@socionext.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcin.s.wojtas@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=michal.kubiak@intel.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=sbhatta@marvell.com \
--cc=sean.wang@mediatek.com \
--cc=sgoutham@marvell.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).