From: Ben Hutchings <benh@debian.org>
To: netdev@vger.kernel.org
Cc: 1088739@bugs.debian.org
Subject: [PATCH iproute2 2/2] color: Do not use dark blue in dark-background palette
Date: Wed, 26 Mar 2025 15:08:56 +0100 [thread overview]
Message-ID: <Z-QKeE-9V2QLyDih@decadent.org.uk> (raw)
In-Reply-To: <Z-QKNa7_nHKoh9Gl@decadent.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
In GNOME Terminal's default dark colour schemes, the default (dark)
blue on a black background is barely readable. Light blue is
significantly more readable to me, and is also easily readable on a
white background.
In Konsole, rxvt, and xterm, I can see little if any difference
between dark and light blue in the default dark colour schemes.
So replace dark blue with light blue in the dark-background palette.
Signed-off-by: Ben Hutchings <benh@debian.org>
---
lib/color.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/color.c b/lib/color.c
index 88ba9b03..aa112352 100644
--- a/lib/color.c
+++ b/lib/color.c
@@ -24,7 +24,7 @@ enum color {
C_BOLD_RED,
C_BOLD_GREEN,
C_BOLD_YELLOW,
- C_BOLD_BLUE,
+ C_BOLD_LIGHT_BLUE,
C_BOLD_MAGENTA,
C_BOLD_CYAN,
C_BOLD_WHITE,
@@ -42,7 +42,7 @@ static const char * const color_codes[] = {
"\e[1;31m",
"\e[1;32m",
"\e[1;33m",
- "\e[1;34m",
+ "\e[1;94m",
"\e[1;35m",
"\e[1;36m",
"\e[1;37m",
@@ -66,7 +66,7 @@ static enum color attr_colors_dark[] = {
C_BOLD_CYAN,
C_BOLD_YELLOW,
C_BOLD_MAGENTA,
- C_BOLD_BLUE,
+ C_BOLD_LIGHT_BLUE,
C_BOLD_GREEN,
C_BOLD_RED,
C_CLEAR
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-03-26 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 14:07 [PATCH iproute2 0/2] Improve coloured text readability Ben Hutchings
2025-03-26 14:08 ` [PATCH iproute2 1/2] color: Assume background is dark if unknown Ben Hutchings
2025-03-26 14:08 ` Ben Hutchings [this message]
2025-04-06 17:00 ` [PATCH iproute2 0/2] Improve coloured text readability patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-QKeE-9V2QLyDih@decadent.org.uk \
--to=benh@debian.org \
--cc=1088739@bugs.debian.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).