From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net v2 05/11] net/mlx5e: use netdev_lockdep_set_classes
Date: Thu, 27 Mar 2025 14:05:06 -0700 [thread overview]
Message-ID: <Z-W9ghVoqyuHsVOH@mini-arch> (raw)
In-Reply-To: <20250327120821.1706c0e3@kernel.org>
On 03/27, Jakub Kicinski wrote:
> On Thu, 27 Mar 2025 06:56:53 -0700 Stanislav Fomichev wrote:
> > Cosmin reports a potential recursive lock warning in [0]. mlx5 is
> > using register_netdevice_notifier_dev_net which might result in
> > iteration over entire netns which triggers lock ordering issues.
> > We know that lower devices are independent, so it's save to
> > suppress the lockdep.
>
> But mlx5 does not use instance locking, yet, so lets defer this one?
SG! Maybe the mlx folks can have it as part of their queue mgmt work?
Cosmin are you ok with adding this to your patch series?
next prev parent reply other threads:[~2025-03-27 21:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 13:56 [PATCH net v2 00/11] net: hold instance lock during NETDEV_UP/REGISTER/UNREGISTER Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 01/11] net: switch to netif_disable_lro in inetdev_init Stanislav Fomichev
2025-03-27 18:40 ` Jakub Kicinski
2025-03-27 18:59 ` Jakub Kicinski
2025-03-27 21:09 ` Stanislav Fomichev
2025-03-27 21:36 ` Jakub Kicinski
2025-03-28 15:01 ` Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 02/11] net: hold instance lock during NETDEV_REGISTER/UP/UNREGISTER Stanislav Fomichev
2025-03-27 18:58 ` Jakub Kicinski
2025-03-27 13:56 ` [PATCH net v2 03/11] net: use netif_disable_lro in ipv6_add_dev Stanislav Fomichev
2025-03-27 19:02 ` Jakub Kicinski
2025-03-27 21:06 ` Stanislav Fomichev
2025-03-27 21:37 ` Jakub Kicinski
2025-03-28 15:01 ` Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 04/11] net: release instance lock during NETDEV_UNREGISTER for bond/team Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 05/11] net/mlx5e: use netdev_lockdep_set_classes Stanislav Fomichev
2025-03-27 19:08 ` Jakub Kicinski
2025-03-27 21:05 ` Stanislav Fomichev [this message]
2025-03-31 8:01 ` Cosmin Ratiu
2025-03-27 13:56 ` [PATCH net v2 06/11] netdevsim: add dummy device notifiers Stanislav Fomichev
2025-03-27 19:12 ` Jakub Kicinski
2025-03-27 21:04 ` Stanislav Fomichev
2025-03-27 21:46 ` Jakub Kicinski
2025-03-28 6:03 ` Kuniyuki Iwashima
2025-03-28 15:07 ` Stanislav Fomichev
2025-03-28 15:04 ` Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 07/11] net: dummy: request ops lock Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 08/11] docs: net: document netdev notifier expectations Stanislav Fomichev
2025-03-27 19:16 ` Jakub Kicinski
2025-03-27 19:34 ` Jakub Kicinski
2025-03-27 20:57 ` Stanislav Fomichev
2025-03-27 21:50 ` Jakub Kicinski
2025-03-28 15:03 ` Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 09/11] net: designate XSK pool pointers in queues as "ops protected" Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 10/11] netdev: add "ops compat locking" helpers Stanislav Fomichev
2025-03-27 13:56 ` [PATCH net v2 11/11] netdev: don't hold rtnl_lock over nl queue info get when possible Stanislav Fomichev
2025-03-28 8:07 ` [PATCH net v2 00/11] net: hold instance lock during NETDEV_UP/REGISTER/UNREGISTER Taehee Yoo
2025-03-28 15:43 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-W9ghVoqyuHsVOH@mini-arch \
--to=stfomichev@gmail.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).