From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
David Wei <dw@davidwei.uk>, Eric Dumazet <edumazet@google.com>,
open list <linux-kernel@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [RFC net 0/1] Fix netdevim to correctly mark NAPI IDs
Date: Mon, 31 Mar 2025 15:32:09 -0700 [thread overview]
Message-ID: <Z-sX6cNBb-mFMhBx@LQ3V64L9R2> (raw)
In-Reply-To: <20250331133615.32bd59b8@kernel.org>
On Mon, Mar 31, 2025 at 01:36:15PM -0700, Jakub Kicinski wrote:
> On Sat, 29 Mar 2025 00:00:28 +0000 Joe Damato wrote:
> > If this net-next material: I'll wait until it reopens and send this
> > patch + an update to busy_poller.c as described above.
>
> Let's stick to net-next.
Sure, sounds good. I'll drop the fixes tag when I resend when
net-next is open, of course.
> Would it be possible / make sense to convert the test to Python
> and move it to drivers/net ?
Hmm. We could; I think originally the busy_poller.c test was added
because it was requested by Paolo for IRQ suspension and netdevsim
was the only option that I could find that supported NAPI IDs at the
time.
busy_poller.c itself seems more like a selftests/net thing since
it's testing some functionality of the core networking code.
Maybe mixing the napi_id != 0 test into busy_poller.c is the wrong
way to go at a higher level. Maybe there should be a test for
netdevsim itself that checks napi_id != 0 and that test would make
more sense under drivers/net vs mixing a check into busy_poller.c?
next prev parent reply other threads:[~2025-03-31 22:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 0:00 [RFC net 0/1] Fix netdevim to correctly mark NAPI IDs Joe Damato
2025-03-29 0:00 ` [RFC net 1/1] netdevsim: Mark NAPI ID on skb in nsim_rcv Joe Damato
2025-03-31 20:36 ` [RFC net 0/1] Fix netdevim to correctly mark NAPI IDs Jakub Kicinski
2025-03-31 22:32 ` Joe Damato [this message]
2025-03-31 23:39 ` Jakub Kicinski
2025-04-15 19:39 ` Joe Damato
2025-04-16 0:11 ` Jakub Kicinski
2025-04-16 1:39 ` Joe Damato
2025-04-16 1:56 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-sX6cNBb-mFMhBx@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox