From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB037624 for ; Wed, 4 Dec 2024 00:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733271559; cv=none; b=WsqTahtshRvGo/8wiXdMupNGLIQuFZJP4o5XCD8bkTBND1oXq3awayMt9/9djorMfo/UsieFHqcxg3xo0IoyFT4pR6chyeCxC4Sf/PDTJQJFcZXezBfWS/9xEzlULSVB750H9cHI5cJ0CnbyRdFOXUP9OSPiiz/aw8PYsi4fy1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733271559; c=relaxed/simple; bh=Y257uBUwrmyY2i150oqTiw5q8OfYxGQUuZJemsejkpw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IKQ8LaxalwR7fjvh9vFIENZhjUU/epWlvPOY0WU7Bp4QpnM0PURwAmwNNQX170vzX+5Ow6WId9R3nRXTi84VUXjlTBUVu6RMHhJyMsFg72mKrWm6mJWa2iFxG37DNCyhVHnsRTbl/u+7sNH5eaIzkMcY53zfDhCH0XcvIDA/UKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EG2cpAV/; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EG2cpAV/" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-724e7d5d5b2so5893214b3a.2 for ; Tue, 03 Dec 2024 16:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733271556; x=1733876356; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lNWxpb6SLG8+B/zGDiEPLBHx/H9rWx/Jzu9Xjt9O2FA=; b=EG2cpAV/m2unmiS0PrD4rp2S2HhIpu/qyakNYtVfbZ71a1x+fN6cQb4MuLaC7JOPcE n/sYH/0AHqSUjyBgttWU0bp7tn9sC5m+rqLdnf3cT6K09KoGbOI00ZA9HxxUKbIk3lBu x61U13POtlmKFMjOHYjUnGD5Z45AZ5+rvEDab8pS0jWoKsqHI1Rx0gZnC7C7G3ck3EPI PECtJ0ge4TTtHqstcFceIB+XeAnVMKoS8+AzAZuiX0cRK49dTWjk7oB6DRFukmcFtlIP NQ0oPSUZ/5bK/NjyT8e7BkI0x3ddx2WJ9+xIysQQt/74K4NaMyVv4w5MUXtMVTXwhd3f MnHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733271556; x=1733876356; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lNWxpb6SLG8+B/zGDiEPLBHx/H9rWx/Jzu9Xjt9O2FA=; b=jGSernhQMA+SBu5qSJF+3gTXMxtV+jiXkNhe5e49zuSCpYb0OU8uMUJl4zyqI8YLHs 3/QTc+ntN+w6IkRd/SKh7hZLrk8Kr7Rr8u0APK0pIOtOKE0evAGH4k1FEU4EtoQHn0eH 1G3kgZzXOTElq9wi1cjmZB8mVwyaiGUaRtEB7VmZVCoVnrcsDGaDqI33M67duZdmXdzL nkvUYEK3pCj5CHd1C0KB08sEecSAGsaZDmmC5ldWrHHdgvByV2PRkUurqs7epcqn/P1A U0gfbkj3/4B6HSZX7w0x/YkIO+CK+oPi9F6rF2nMOugEJTfmqzP41/XAhTDWkFvW2fKs nFOg== X-Gm-Message-State: AOJu0YxcMutugunl7Tz2EBrG2BrG6nwSUIFLE2O6+OlrClYTWfpukofj vVAid8FKjeviRl0Bnd4MyW6900RuQzO3yO1HUvOW5NZrXE7YpE7X X-Gm-Gg: ASbGnct6oBzEDVKnnBA9eudN5agnnBijlTLK1kaCoBJRrG9Xy3UsEpRgZkChaoRl0Ha SblRdVpHrPqZnYZB31wOp7YLMWvET9sDtXWwct3xQYhihX0If7vuJaPdOsanHtlxbCDEB046ALc V3FofKKxh1fSJEZs/CZ9r+lmMTmuCQZMzsf8zDThndpQkrcN2Xkz0fot0yAgoODzYBtJVyxASXo HANfyNp6uIc4BQKXb3/NHfMKH9UHZr5Ir+ge1OQYUlVL21c/zeTWp3O X-Google-Smtp-Source: AGHT+IH/w0OcegImumeF+DlJITTJ62mvzWmRWrorlEIG0wulp2bhAVD9op84cl9eKsTfxAO8JNiwXQ== X-Received: by 2002:a05:6a00:3d4a:b0:71e:581f:7d7e with SMTP id d2e1a72fcca58-7257fc7991emr6191916b3a.15.1733271556123; Tue, 03 Dec 2024 16:19:16 -0800 (PST) Received: from localhost ([2601:647:6881:9060:32d6:f9ea:3b48:6054]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725417fbffasm11464532b3a.103.2024.12.03.16.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 16:19:15 -0800 (PST) Date: Tue, 3 Dec 2024 16:19:14 -0800 From: Cong Wang To: Xin Long Cc: network dev , davem@davemloft.net, kuba@kernel.org, Eric Dumazet , Paolo Abeni , Jamal Hadi Salim , Jiri Pirko , Davide Caratti , Simon Horman , Shuang Li Subject: Re: [PATCHv2 net] net: sched: fix erspan_opt settings in cls_flower Message-ID: References: <981381d3d1aaa4f81619145180e06338af487a42.1733152898.git.lucien.xin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <981381d3d1aaa4f81619145180e06338af487a42.1733152898.git.lucien.xin@gmail.com> On Mon, Dec 02, 2024 at 10:21:38AM -0500, Xin Long wrote: > When matching erspan_opt in cls_flower, only the (version, dir, hwid) > fields are relevant. However, in fl_set_erspan_opt() it initializes > all bits of erspan_opt and its mask to 1. This inadvertently requires > packets to match not only the (version, dir, hwid) fields but also the > other fields that are unexpectedly set to 1. > > This patch resolves the issue by ensuring that only the (version, dir, > hwid) fields are configured in fl_set_erspan_opt(), leaving the other > fields to 0 in erspan_opt. > > Fixes: 79b1011cb33d ("net: sched: allow flower to match erspan options") > Reported-by: Shuang Li > Signed-off-by: Xin Long Reviewed-by: Cong Wang Looking forward to your selftest. :) Thanks.