From: Cong Wang <xiyou.wangcong@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Victor Nogueira <victor@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net_sched: sch_fq: add three drop_reason
Date: Tue, 3 Dec 2024 16:47:45 -0800 [thread overview]
Message-ID: <Z0+mseLf3mn9mFxz@pop-os.localdomain> (raw)
In-Reply-To: <20241203210929.3281461-1-edumazet@google.com>
On Tue, Dec 03, 2024 at 09:09:29PM +0000, Eric Dumazet wrote:
> Add three new drop_reason, more precise than generic QDISC_DROP:
>
> "tc -s qd" show aggregate counters, it might be more useful
> to use drop_reason infrastructure for bug hunting.
>
> 1) SKB_DROP_REASON_FQ_DROP_BAND_LIMIT
> Whenever a packet is added while its band limit is hit.
> Corresponding value in "tc -s qd" is bandX_drops XXXX
>
> 2) SKB_DROP_REASON_FQ_DROP_HORIZON_LIMIT
> Whenever a packet has a timestamp too far in the future.
> Corresponding value in "tc -s qd" is horizon_drops XXXX
>
> 3) SKB_DROP_REASON_FQ_DROP_FLOW_LIMIT
> Whenever a flow has reached its limit.
> Corresponding value in "tc -s qd" is flows_plimit XXXX
>
Just a nit: maybe remove the second "DROP" in these long names?
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
Thanks.
next prev parent reply other threads:[~2024-12-04 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 21:09 [PATCH net-next] net_sched: sch_fq: add three drop_reason Eric Dumazet
2024-12-04 0:47 ` Cong Wang [this message]
2024-12-04 7:39 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0+mseLf3mn9mFxz@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox