* [PATCH] selftests/net: call sendmmsg via udpgso_bench.sh
@ 2024-12-02 23:21 Kenjiro Nakayama
2024-12-03 2:00 ` Hangbin Liu
2024-12-03 15:21 ` Willem de Bruijn
0 siblings, 2 replies; 3+ messages in thread
From: Kenjiro Nakayama @ 2024-12-02 23:21 UTC (permalink / raw)
To: Pablo Neira Ayuso, Jozsef Kadlecsik, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Alan Stern, Andrea Parri, Will Deacon, Peter Zijlstra, Boqun Feng,
Nicholas Piggin, David Howells, Jade Alglave, Luc Maranget,
Paul E. McKenney, Akira Yokosawa, Daniel Lustig, Joel Fernandes,
Shuah Khan
Cc: netfilter-devel, coreteam, linux-kernel, netdev, linux-arch, lkmm,
linux-kselftest, Kenjiro Nakayama
Currently, sendmmsg is implemented in udpgso_bench_tx.c,
but it is not called by any test script.
This patch adds a test for sendmmsg in udpgso_bench.sh.
This allows for basic API testing and benchmarking
comparisons with GSO.
---
tools/testing/selftests/net/udpgso_bench.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
index 640bc43452fa..88fa1d53ba2b 100755
--- a/tools/testing/selftests/net/udpgso_bench.sh
+++ b/tools/testing/selftests/net/udpgso_bench.sh
@@ -92,6 +92,9 @@ run_udp() {
echo "udp"
run_in_netns ${args}
+ echo "udp sendmmsg"
+ run_in_netns ${args} -m
+
echo "udp gso"
run_in_netns ${args} -S 0
--
2.39.3 (Apple Git-146)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/net: call sendmmsg via udpgso_bench.sh
2024-12-02 23:21 [PATCH] selftests/net: call sendmmsg via udpgso_bench.sh Kenjiro Nakayama
@ 2024-12-03 2:00 ` Hangbin Liu
2024-12-03 15:21 ` Willem de Bruijn
1 sibling, 0 replies; 3+ messages in thread
From: Hangbin Liu @ 2024-12-03 2:00 UTC (permalink / raw)
To: Kenjiro Nakayama
Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Alan Stern, Andrea Parri, Will Deacon, Peter Zijlstra, Boqun Feng,
Nicholas Piggin, David Howells, Jade Alglave, Luc Maranget,
Paul E. McKenney, Akira Yokosawa, Daniel Lustig, Joel Fernandes,
Shuah Khan, netfilter-devel, coreteam, linux-kernel, netdev,
linux-arch, lkmm, linux-kselftest
On Tue, Dec 03, 2024 at 08:21:29AM +0900, Kenjiro Nakayama wrote:
> Currently, sendmmsg is implemented in udpgso_bench_tx.c,
> but it is not called by any test script.
>
> This patch adds a test for sendmmsg in udpgso_bench.sh.
> This allows for basic API testing and benchmarking
> comparisons with GSO.
> ---
> tools/testing/selftests/net/udpgso_bench.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
> index 640bc43452fa..88fa1d53ba2b 100755
> --- a/tools/testing/selftests/net/udpgso_bench.sh
> +++ b/tools/testing/selftests/net/udpgso_bench.sh
> @@ -92,6 +92,9 @@ run_udp() {
> echo "udp"
> run_in_netns ${args}
>
> + echo "udp sendmmsg"
> + run_in_netns ${args} -m
> +
> echo "udp gso"
> run_in_netns ${args} -S 0
>
> --
> 2.39.3 (Apple Git-146)
>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/net: call sendmmsg via udpgso_bench.sh
2024-12-02 23:21 [PATCH] selftests/net: call sendmmsg via udpgso_bench.sh Kenjiro Nakayama
2024-12-03 2:00 ` Hangbin Liu
@ 2024-12-03 15:21 ` Willem de Bruijn
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2024-12-03 15:21 UTC (permalink / raw)
To: Kenjiro Nakayama, Pablo Neira Ayuso, Jozsef Kadlecsik,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Alan Stern, Andrea Parri, Will Deacon,
Peter Zijlstra, Boqun Feng, Nicholas Piggin, David Howells,
Jade Alglave, Luc Maranget, Paul E. McKenney, Akira Yokosawa,
Daniel Lustig, Joel Fernandes, Shuah Khan
Cc: netfilter-devel, coreteam, linux-kernel, netdev, linux-arch, lkmm,
linux-kselftest, Kenjiro Nakayama
Kenjiro Nakayama wrote:
> Currently, sendmmsg is implemented in udpgso_bench_tx.c,
> but it is not called by any test script.
>
> This patch adds a test for sendmmsg in udpgso_bench.sh.
> This allows for basic API testing and benchmarking
> comparisons with GSO.
The change looks fine to me, but the commit is missing your
Signed-off-by.
Also, if resubmitting, please mark [PATCH net-next v2].
> ---
> tools/testing/selftests/net/udpgso_bench.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
> index 640bc43452fa..88fa1d53ba2b 100755
> --- a/tools/testing/selftests/net/udpgso_bench.sh
> +++ b/tools/testing/selftests/net/udpgso_bench.sh
> @@ -92,6 +92,9 @@ run_udp() {
> echo "udp"
> run_in_netns ${args}
>
> + echo "udp sendmmsg"
> + run_in_netns ${args} -m
> +
> echo "udp gso"
> run_in_netns ${args} -S 0
>
> --
> 2.39.3 (Apple Git-146)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-03 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-02 23:21 [PATCH] selftests/net: call sendmmsg via udpgso_bench.sh Kenjiro Nakayama
2024-12-03 2:00 ` Hangbin Liu
2024-12-03 15:21 ` Willem de Bruijn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).