netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Dege <michael.dege@renesas.com>,
	Christian Mardmoeller <christian.mardmoeller@renesas.com>,
	Dennis Ostermann <dennis.ostermann@renesas.com>
Subject: Re: [PATCH] net: phy: phy_ethtool_ksettings_set: Allow any supported speed
Date: Tue, 3 Dec 2024 15:15:27 +0000	[thread overview]
Message-ID: <Z08gj2ImILpSALDn@shell.armlinux.org.uk> (raw)
In-Reply-To: <2836f456-aac4-4925-97d6-25f6613fe998@cogentembedded.com>

On Tue, Dec 03, 2024 at 04:01:56PM +0500, Nikita Yushchenko wrote:
> > As I say, need to see the code. Otherwise... sorry, I'm no longer
> > interested in your problem.
> 
> We already got valuable information.
> 
> I agree that the patch I tried to submit is a wrong way to handle the issue
> we have. Instead, need to improve the PHY driver stub, such that it does not
> declare no autoneg support for 2.5G Base-T1 PHY.
> 
> (creating a real driver for the PHY is not possible at this time due to lack of technical information)

Even seeing the existing code would help, rather than the current
situation which means we're poking about in total darkness. It doesn't
need to be "mainline quality". There is nothing worse for a maintainer
than to have someone trying to fix a problem, but not be able to know
the full details.

We're not asking for "a real driver", but just _seeing_ what the driver
is currently doing will help to answer questions such as why
phydev->duplex is changing.

Not being able to see what a driver is doing is very demotivating.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2024-12-03 15:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02  8:33 [PATCH] net: phy: phy_ethtool_ksettings_set: Allow any supported speed Nikita Yushchenko
2024-12-02  9:03 ` Maxime Chevallier
2024-12-02  9:20   ` Nikita Yushchenko
2024-12-02  9:59     ` Maxime Chevallier
2024-12-02 10:10     ` Russell King (Oracle)
2024-12-02 10:17       ` Nikita Yushchenko
2024-12-02 10:23         ` Russell King (Oracle)
2024-12-02 11:09           ` Nikita Yushchenko
2024-12-02 12:30             ` Russell King (Oracle)
2024-12-02 15:51               ` Nikita Yushchenko
2024-12-02 16:03                 ` Russell King (Oracle)
2024-12-03 11:01                   ` Nikita Yushchenko
2024-12-03 15:15                     ` Russell King (Oracle) [this message]
2024-12-03 14:05                   ` Dennis Ostermann
2024-12-03 14:45                     ` Andrew Lunn
2024-12-03 15:21                       ` Russell King (Oracle)
2024-12-03 15:51                         ` Maxime Chevallier
2024-12-03 16:37                           ` Russell King (Oracle)
2024-12-02 14:32             ` Andrew Lunn
2024-12-02 10:03 ` Russell King (Oracle)
2024-12-03 14:02   ` Nikita Yushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z08gj2ImILpSALDn@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=christian.mardmoeller@renesas.com \
    --cc=davem@davemloft.net \
    --cc=dennis.ostermann@renesas.com \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=michael.dege@renesas.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).