From: Cong Wang <xiyou.wangcong@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: Frederik Deweerdt <deweerdt.lkml@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net] splice: do not checksum AF_UNIX sockets
Date: Tue, 3 Dec 2024 13:48:56 -0800 [thread overview]
Message-ID: <Z098yHlrNYJsdzhM@pop-os.localdomain> (raw)
In-Reply-To: <537172.1733243422@warthog.procyon.org.uk>
On Tue, Dec 03, 2024 at 04:30:22PM +0000, David Howells wrote:
> Frederik Deweerdt <deweerdt.lkml@gmail.com> wrote:
>
> > - if (skb->ip_summed == CHECKSUM_NONE)
> > + if (skb->ip_summed == CHECKSUM_NONE && skb->sk->sk_family != AF_UNIX)
> > skb_splice_csum_page(skb, page, off, part);
>
> Should AF_UNIX set some other CHECKSUM_* constant indicating that the checksum
> is unnecessary?
>
It already means unnecessary on TX path:
* - %CHECKSUM_NONE
*
* The skb was already checksummed by the protocol, or a checksum is not
* required.
Thanks.
next prev parent reply other threads:[~2024-12-03 21:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 23:20 [PATCH net] splice: do not checksum AF_UNIX sockets Frederik Deweerdt
2024-11-30 1:43 ` Cong Wang
2024-11-30 4:05 ` Frederik Deweerdt
2024-11-30 12:08 ` David Laight
2024-12-03 16:30 ` David Howells
2024-12-03 21:48 ` Cong Wang [this message]
2024-12-03 22:35 ` Frederik Deweerdt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z098yHlrNYJsdzhM@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=deweerdt.lkml@gmail.com \
--cc=dhowells@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox