* [syzbot] [netfilter?] BUG: using smp_processor_id() in preemptible code in nft_inner_eval
@ 2024-11-22 0:02 syzbot
2024-11-22 13:32 ` [PATCH] netfilter: nf_tables: Use get_cpu_ptr " Pei Xiao
0 siblings, 1 reply; 4+ messages in thread
From: syzbot @ 2024-11-22 0:02 UTC (permalink / raw)
To: coreteam, davem, edumazet, horms, kadlec, kuba, linux-kernel,
netdev, netfilter-devel, pabeni, pablo, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: 43fb83c17ba2 Merge tag 'soc-arm-6.13' of git://git.kernel...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17da1b78580000
kernel config: https://syzkaller.appspot.com/x/.config?x=e796b1bf154f93a7
dashboard link: https://syzkaller.appspot.com/bug?extid=84d0441b9860f0d63285
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/cdcbc016316b/disk-43fb83c1.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f82505daa7c2/vmlinux-43fb83c1.xz
kernel image: https://storage.googleapis.com/syzbot-assets/74b0b41d70c6/bzImage-43fb83c1.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+84d0441b9860f0d63285@syzkaller.appspotmail.com
check_preemption_disabled: 3425 callbacks suppressed
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 1 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 0 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 0 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 0 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 0 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 0 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 0 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 0 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 0 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 1 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1c1ff7e819
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c20db5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007f1c20135fa0 RCX: 00007f1c1ff7e819
RDX: 000000000000002d RSI: 0000000020007fc0 RDI: 0000000000000007
RBP: 00007f1c1fff175e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1c20135fa0 R15: 00007ffef663cd18
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] netfilter: nf_tables: Use get_cpu_ptr in nft_inner_eval
2024-11-22 0:02 [syzbot] [netfilter?] BUG: using smp_processor_id() in preemptible code in nft_inner_eval syzbot
@ 2024-11-22 13:32 ` Pei Xiao
2024-11-22 13:45 ` Florian Westphal
0 siblings, 1 reply; 4+ messages in thread
From: Pei Xiao @ 2024-11-22 13:32 UTC (permalink / raw)
To: pablo, kadlec, davem, kuba, pabeni, horms, netfilter-devel,
netdev, linux-kernel, syzbot+84d0441b9860f0d63285
Cc: syzkaller-bugs, Pei Xiao
syzbot complain about using smp_processor_id in preemptible.
use get_cpu_ptr to preempt_disable.
BUG: using smp_processor_id() in preemptible [00000000] code: syz.3.1627/12102
caller is nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
CPU: 1 UID: 0 PID: 12102 Comm: syz.3.1627 Not tainted 6.12.0-syzkaller-03657-g43fb83c17ba2 #0
Hardware name: Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
check_preemption_disabled+0x10e/0x120 lib/smp_processor_id.c:49
nft_inner_eval+0xda/0x18e0 net/netfilter/nft_inner.c:251
expr_call_ops_eval net/netfilter/nf_tables_core.c:240 [inline]
nft_do_chain+0x4ad/0x1da0 net/netfilter/nf_tables_core.c:288
nft_do_chain_ipv4+0x202/0x320 net/netfilter/nft_chain_filter.c:23
nf_hook_entry_hookfn include/linux/netfilter.h:154 [inline]
nf_hook_slow+0xc3/0x220 net/netfilter/core.c:626
nf_hook+0x2c4/0x450 include/linux/netfilter.h:269
NF_HOOK_COND include/linux/netfilter.h:302 [inline]
ip_output+0x185/0x230 net/ipv4/ip_output.c:434
ip_local_out net/ipv4/ip_output.c:130 [inline]
ip_send_skb+0x74/0x100 net/ipv4/ip_output.c:1496
udp_send_skb+0xab6/0x1630 net/ipv4/udp.c:984
udp_sendmsg+0x1c21/0x2a60 net/ipv4/udp.c:1272
sock_sendmsg_nosec net/socket.c:711 [inline]
__sock_sendmsg+0x1a6/0x270 net/socket.c:726
____sys_sendmsg+0x52a/0x7e0 net/socket.c:2581
___sys_sendmsg net/socket.c:2635 [inline]
__sys_sendmmsg+0x36a/0x720 net/socket.c:2724
__do_sys_sendmmsg net/socket.c:2751 [inline]
__se_sys_sendmmsg net/socket.c:2748 [inline]
__x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2748
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Reported-by: syzbot+84d0441b9860f0d63285@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=84d0441b9860f0d63285
Fixes: 0e795b37ba04 ("netfilter: nft_inner: add percpu inner context")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
net/netfilter/nft_inner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_inner.c b/net/netfilter/nft_inner.c
index 928312d01eb1..ae85851bab77 100644
--- a/net/netfilter/nft_inner.c
+++ b/net/netfilter/nft_inner.c
@@ -248,7 +248,7 @@ static bool nft_inner_parse_needed(const struct nft_inner *priv,
static void nft_inner_eval(const struct nft_expr *expr, struct nft_regs *regs,
const struct nft_pktinfo *pkt)
{
- struct nft_inner_tun_ctx *tun_ctx = this_cpu_ptr(&nft_pcpu_tun_ctx);
+ struct nft_inner_tun_ctx *tun_ctx = get_cpu_ptr(&nft_pcpu_tun_ctx);
const struct nft_inner *priv = nft_expr_priv(expr);
if (nft_payload_inner_offset(pkt) < 0)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: nf_tables: Use get_cpu_ptr in nft_inner_eval
2024-11-22 13:32 ` [PATCH] netfilter: nf_tables: Use get_cpu_ptr " Pei Xiao
@ 2024-11-22 13:45 ` Florian Westphal
2024-11-22 13:51 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Florian Westphal @ 2024-11-22 13:45 UTC (permalink / raw)
To: Pei Xiao
Cc: pablo, kadlec, davem, kuba, pabeni, horms, netfilter-devel,
netdev, linux-kernel, syzbot+84d0441b9860f0d63285, syzkaller-bugs
Pei Xiao <xiaopei01@kylinos.cn> wrote:
> syzbot complain about using smp_processor_id in preemptible.
> use get_cpu_ptr to preempt_disable.
> Reported-by: syzbot+84d0441b9860f0d63285@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=84d0441b9860f0d63285
> Fixes: 0e795b37ba04 ("netfilter: nft_inner: add percpu inner context")
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
> net/netfilter/nft_inner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nft_inner.c b/net/netfilter/nft_inner.c
> index 928312d01eb1..ae85851bab77 100644
> --- a/net/netfilter/nft_inner.c
> +++ b/net/netfilter/nft_inner.c
> @@ -248,7 +248,7 @@ static bool nft_inner_parse_needed(const struct nft_inner *priv,
> static void nft_inner_eval(const struct nft_expr *expr, struct nft_regs *regs,
> const struct nft_pktinfo *pkt)
> {
> - struct nft_inner_tun_ctx *tun_ctx = this_cpu_ptr(&nft_pcpu_tun_ctx);
> + struct nft_inner_tun_ctx *tun_ctx = get_cpu_ptr(&nft_pcpu_tun_ctx);
> const struct nft_inner *priv = nft_expr_priv(expr);
This can't be right, where is it re-enabled?
Not related to your patch:
Why is this percpu? How is this softirq safe?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: nf_tables: Use get_cpu_ptr in nft_inner_eval
2024-11-22 13:45 ` Florian Westphal
@ 2024-11-22 13:51 ` Pablo Neira Ayuso
0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2024-11-22 13:51 UTC (permalink / raw)
To: Florian Westphal
Cc: Pei Xiao, kadlec, davem, kuba, pabeni, horms, netfilter-devel,
netdev, linux-kernel, syzbot+84d0441b9860f0d63285, syzkaller-bugs
On Fri, Nov 22, 2024 at 02:45:29PM +0100, Florian Westphal wrote:
> Pei Xiao <xiaopei01@kylinos.cn> wrote:
> > syzbot complain about using smp_processor_id in preemptible.
> > use get_cpu_ptr to preempt_disable.
>
> > Reported-by: syzbot+84d0441b9860f0d63285@syzkaller.appspotmail.com
> > Closes: https://syzkaller.appspot.com/bug?extid=84d0441b9860f0d63285
> > Fixes: 0e795b37ba04 ("netfilter: nft_inner: add percpu inner context")
> > Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> > ---
> > net/netfilter/nft_inner.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/netfilter/nft_inner.c b/net/netfilter/nft_inner.c
> > index 928312d01eb1..ae85851bab77 100644
> > --- a/net/netfilter/nft_inner.c
> > +++ b/net/netfilter/nft_inner.c
> > @@ -248,7 +248,7 @@ static bool nft_inner_parse_needed(const struct nft_inner *priv,
> > static void nft_inner_eval(const struct nft_expr *expr, struct nft_regs *regs,
> > const struct nft_pktinfo *pkt)
> > {
> > - struct nft_inner_tun_ctx *tun_ctx = this_cpu_ptr(&nft_pcpu_tun_ctx);
> > + struct nft_inner_tun_ctx *tun_ctx = get_cpu_ptr(&nft_pcpu_tun_ctx);
> > const struct nft_inner *priv = nft_expr_priv(expr);
>
> This can't be right, where is it re-enabled?
>
> Not related to your patch:
> Why is this percpu? How is this softirq safe?
I can add an owner skbuff to nft_inner_tun_ctx area, so this
information can be canceled in case of softirq interference, then
trigger a reparsing of the header.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-22 13:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-22 0:02 [syzbot] [netfilter?] BUG: using smp_processor_id() in preemptible code in nft_inner_eval syzbot
2024-11-22 13:32 ` [PATCH] netfilter: nf_tables: Use get_cpu_ptr " Pei Xiao
2024-11-22 13:45 ` Florian Westphal
2024-11-22 13:51 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).