From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD3B165F04 for ; Sat, 23 Nov 2024 06:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732343410; cv=none; b=kZDN4Nt0g5hqINh/de34X3aLEashpSIXRps2Itu+hDNMI9/4h3BnTQHaUW6XCQgUrX//oO4rciUzMNLeNUqsDckVe1Ku2ok8t+0GDzcHLx/vTDUa4LJxuH6H8nHNSBPlRrkipbcDWaUo5ylbstrLX3/C3FVm3rXJwq3glDUU0RY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732343410; c=relaxed/simple; bh=ZFSqsP1ToYIdl2SVy8ukEWvyI5D3U02Lmf2RdX5RNxk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eDbpGIvtm1wsyV/E/H0VVDsfCPMpjlfwgHYPqGzO9qcu+GKbSstu9N2v8knv3TJI3myCC1Piamsd7tonqFqrG9QwHBblYDjvgVWsAwBk9qV4QKve1L6znWVNjmnB29KFRQs81PWKbs/wsIVMEWkVRqrZlSJhxv2GipDUAZ0OFzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEjeB-00076W-J9; Sat, 23 Nov 2024 07:29:35 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tEje5-002C31-2A; Sat, 23 Nov 2024 07:29:29 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tEje5-00Aoon-1l; Sat, 23 Nov 2024 07:29:29 +0100 Date: Sat, 23 Nov 2024 07:29:29 +0100 From: Oleksij Rempel To: Kory Maincent Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Donald Hunter , Rob Herring , Andrew Lunn , Simon Horman , Heiner Kallweit , Russell King , Liam Girdwood , Mark Brown , Thomas Petazzoni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, Kyle Swenson , Dent Project , kernel@pengutronix.de, Maxime Chevallier Subject: Re: [PATCH RFC net-next v3 03/27] net: pse-pd: Avoid setting max_uA in regulator constraints Message-ID: References: <20241121-feature_poe_port_prio-v3-0-83299fa6967c@bootlin.com> <20241121-feature_poe_port_prio-v3-3-83299fa6967c@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241121-feature_poe_port_prio-v3-3-83299fa6967c@bootlin.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Hi Kory, On Thu, Nov 21, 2024 at 03:42:29PM +0100, Kory Maincent wrote: > From: Kory Maincent (Dent Project) > > Setting the max_uA constraint in the regulator API imposes a current > limit during the regulator registration process. This behavior conflicts > with preserving the maximum PI power budget configuration across reboots. > > Instead, compare the desired current limit to MAX_PI_CURRENT in the > pse_pi_set_current_limit() function to ensure proper handling of the > power budget. Not enough coffee :) I still didn't correctly understood the problem. MAX_PI_CURRENT is the hard limit according to the standard, so it is the intial limit anyway. Why it is bad to set it on registration? It feels still better compared to have no limit on init. Or do i'm missing things? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |