From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Michal Kubecek <mkubecek@suse.cz>,
kernel@pengutronix.de, netdev@vger.kernel.org
Subject: Re: [PATCH v2] ethtool: add support for ETHTOOL_A_CABLE_FAULT_LENGTH_SRC and ETHTOOL_A_CABLE_RESULT_SRC
Date: Fri, 29 Nov 2024 07:11:39 +0100 [thread overview]
Message-ID: <Z0lbGyg99mNN4V7L@pengutronix.de> (raw)
In-Reply-To: <9d8b7d97-75b8-4e39-91c5-dd56b157ce84@lunn.ch>
On Thu, Nov 28, 2024 at 06:41:11PM +0100, Andrew Lunn wrote:
> > > ETHTOOL_A_CABLE_RESULT_SRC is a new property, so only newer kernels
> > > will report it. I think you need an
> > > if (tb[ETHTOOL_A_CABLE_RESULT_SRC]) here, and anywhere else you look for
> > > this property?
> >
> > Looks like a forgotten edit of copy&pasted text
>
> Duh! Yes, i did forget.
Arrr... i check existence of wrong field... (-‸ლ)
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-11-29 6:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 9:01 [PATCH v2] ethtool: add support for ETHTOOL_A_CABLE_FAULT_LENGTH_SRC and ETHTOOL_A_CABLE_RESULT_SRC Oleksij Rempel
2024-11-28 10:09 ` [PATCH ethtool " Oleksij Rempel
2024-11-28 16:58 ` [PATCH " Andrew Lunn
2024-11-28 17:36 ` Michal Kubecek
2024-11-28 17:41 ` Andrew Lunn
2024-11-29 6:11 ` Oleksij Rempel [this message]
2024-11-29 14:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0lbGyg99mNN4V7L@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=kernel@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).