netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Divya.Koppera@microchip.com, Arun.Ramadoss@microchip.com,
	UNGLinuxDriver@microchip.com, hkallweit1@gmail.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, richardcochran@gmail.com,
	vadim.fedorenko@linux.dev
Subject: Re: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in Microchip phys
Date: Wed, 4 Dec 2024 16:09:23 +0000	[thread overview]
Message-ID: <Z1B-s8-p1QC9SKGr@shell.armlinux.org.uk> (raw)
In-Reply-To: <ee883c7a-f8af-4de6-b7d3-90e883af7dec@lunn.ch>

On Wed, Dec 04, 2024 at 05:02:46PM +0100, Andrew Lunn wrote:
> > > How many different PTP implementations does Microchip have?
> > > 
> > > I see mscc_ptp.c, lan743x_ptp.c, lan966x_ptp.c and sparx5_ptp.c. Plus this
> > > one.
> > > 
> > 
> > These are MAC specific PTP. The library that we implemented is for PHYs.
> 
> And the difference is? Marvell has one PTP implementation they use in
> the PHYs and MACs in Ethernet switches. The basic core is the same,
> with different wrappers around it.

... and I have code that implements a library for Marvell PTP, which is
dependent on the timestamping stuff getting sorted. I tested it
recently, and at least the user API wasn't working as intended in
mainline kernels.

When we actually get to a point where we can choose between the MAC and
the PHY timestamper, I'll go back to working on that library. Sadly,
that's not yet.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2024-12-04 16:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  8:52 [PATCH net-next v5 0/5] Add ptp library for Microchip phys Divya Koppera
2024-12-03  8:52 ` [PATCH net-next v5 1/5] net: phy: microchip_ptp : Add header file for Microchip ptp library Divya Koppera
2024-12-03  8:52 ` [PATCH net-next v5 2/5] net: phy: microchip_ptp : Add ptp library for Microchip phys Divya Koppera
2024-12-05  9:47   ` Paolo Abeni
2024-12-05 11:00     ` Divya.Koppera
2024-12-05 11:07       ` Paolo Abeni
2024-12-05 11:26         ` Divya.Koppera
2024-12-03  8:52 ` [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in " Divya Koppera
2024-12-04  1:39   ` Andrew Lunn
2024-12-04 15:47     ` Divya.Koppera
2024-12-04 16:02       ` Andrew Lunn
2024-12-04 16:09         ` Russell King (Oracle) [this message]
2024-12-05  6:04         ` Divya.Koppera
2024-12-05 14:35           ` Andrew Lunn
2024-12-06 11:30             ` Divya.Koppera
2024-12-03  8:52 ` [PATCH net-next v5 4/5] net: phy: Makefile: Add makefile support for ptp " Divya Koppera
2024-12-03  8:52 ` [PATCH net-next v5 5/5] net: phy: microchip_t1 : Add initialization of ptp for lan887x Divya Koppera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1B-s8-p1QC9SKGr@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=Arun.Ramadoss@microchip.com \
    --cc=Divya.Koppera@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).